From owner-freebsd-current@FreeBSD.ORG  Tue Jun  3 21:36:57 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 90232106567C
	for <current@freebsd.org>; Tue,  3 Jun 2008 21:36:57 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
	[IPv6:2001:470:1f10:75::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 306868FC29
	for <current@freebsd.org>; Tue,  3 Jun 2008 21:36:57 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1])
	(authenticated bits=0)
	by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m53Lalpb076412;
	Tue, 3 Jun 2008 17:36:48 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Ian FREISLICH <ianf@clue.co.za>
Date: Tue, 3 Jun 2008 17:35:59 -0400
User-Agent: KMail/1.9.7
References: <E1K3cPm-0000VN-Ss@clue.co.za>
In-Reply-To: <E1K3cPm-0000VN-Ss@clue.co.za>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200806031735.59591.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]);
	Tue, 03 Jun 2008 17:36:48 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.91.2/7349/Tue Jun 3 15:20:43 2008 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.6 required=4.2 tests=BAYES_00,NO_RELAYS 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: current@freebsd.org
Subject: Re: xe(4) MPSAFE patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jun 2008 21:36:57 -0000

On Tuesday 03 June 2008 03:43:26 pm Ian FREISLICH wrote:
> Ian FREISLICH wrote:
> > John Baldwin wrote:
> > > I actually broke the timer (it only ran once and didn't reschedule
> > > itself) and it also was going to emit the warning each time it ran
> > > even if there wasn't an actual timeout.  I've fixed both issues and
> > > updated the patch at the URL again.
> >
> > Ok, I'll try it again tonight.
> 
> Seems to work
> 
> xe0: <Xircom RealPort Ethernet 10/100 + Modem 56> at port 0x2e8-0x2ef irq 11 
function 0 config 39 on pccard0
> xe0: version 0x55/0x05, 100Mbps capable, with modem
> xe0: Ethernet address: 00:10:a4:b6:0a:32
> xe0: [ITHREAD]
> 
> and no more watchdog timeouts

Cool, thanks.  If you are still up for testing, try out 
http://www.FreeBSD.org/~jhb/patches/xe_intr.patch

It uses the bus_read API instead of bus_space and splits the interrupt handler 
up into sub-functions for tx/rx/MAC events.

-- 
John Baldwin