From owner-svn-src-all@freebsd.org Sat Jan 30 01:15:19 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 319F2A73393 for ; Sat, 30 Jan 2016 01:15:19 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C71671CB8 for ; Sat, 30 Jan 2016 01:15:18 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: by mail-wm0-x22e.google.com with SMTP id p63so2110483wmp.1 for ; Fri, 29 Jan 2016 17:15:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=P6Zo3bbPSCZ/Y3jiBzK8msiD7OsMX4/POgeC94piH7o=; b=o9Ypw8K9kyIsP1HRSOuuZj+ar249wez/UZ+/0SDrdj8H3nhobq+aPyelOJVPhfywHB 7McZy811uYv4ZXV9BA+oJyLTVcDJBorIRS8wwYs02dENWNSZCe8zbwrQnmHheo15F4cO DAi+zHK34fL49GR39LX3szTnE7/ml/3pKcwZtS9sqc+5aW5eh4foiYE7KJB9iB5JrvXX TQI6yrhlivOVcB5gTx/pslJ8yBTtt/qvRAlleIknI4Q/NAUxEZBSPqvvDyHIRrqd5sBN PyjSijdzpdEVaL+3WVqwWsINKee68wFAyupJZakFZmil8pMJIsLe7g5F6hVFtqSO/jU5 Rc4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=P6Zo3bbPSCZ/Y3jiBzK8msiD7OsMX4/POgeC94piH7o=; b=muBJKULfOHG4t4zQtTO1bxcwZ5Zo9w9K1ArsGkJu+fjRNmOVvgZrPwuCVcoojF6e9w vOlNNJegX4XZIzXT28iBXYVjpbCNicd1nFO5qcweomGUsvVpPmEyDPMeS0Kj9WcEIHll t76RQDofQclOy1JKiOA9lMtWfAflIRbfkYUi7Cl4C5G/hkSY9NyT75AeYxwehPKDioQs 94hDfOLwJLX1xo9uZLM/SoGu8gwmcBiyv2QbKEFejHx6aCCqzi4VweUkmf8FDwoiZDvU GhNc3nqfE0+mn1QDMFe900OL/+VEIKnDiISXFpBL9M+T18puwwcP0BtdeiOTCFXJubHo 4EpQ== X-Gm-Message-State: AG10YOQqYfPxDI79vNKvN3JcEdxBeJjkGjzZTWTt1dYGWcctLpYu4/KrACCs6+nyQZsxb2bA X-Received: by 10.194.240.66 with SMTP id vy2mr11593066wjc.28.1454116516867; Fri, 29 Jan 2016 17:15:16 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id q75sm313548wmd.6.2016.01.29.17.15.15 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 29 Jan 2016 17:15:15 -0800 (PST) Subject: Re: svn commit: r295051 - head/sys/dev/ixl To: Steven Hartland , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201601292106.u0TL6xN0043129@repo.freebsd.org> From: Steven Hartland Message-ID: <56AC0EB4.3030109@multiplay.co.uk> Date: Sat, 30 Jan 2016 01:15:32 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <201601292106.u0TL6xN0043129@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jan 2016 01:15:19 -0000 This should have referenced https://reviews.freebsd.org/D5106 On 29/01/2016 21:06, Steven Hartland wrote: > Author: smh > Date: Fri Jan 29 21:06:59 2016 > New Revision: 295051 > URL: https://svnweb.freebsd.org/changeset/base/295051 > > Log: > Fix phy interrupts setup for ixl > > Fix the inverted set of interrupts being used as the mask for ixl. > > Without this ixl devices fail to detect link state changes. > > Reviewed by: erj, sbruno > MFC after: 2 days > Sponsored by: Multiplay > > Modified: > head/sys/dev/ixl/if_ixl.c > > Modified: head/sys/dev/ixl/if_ixl.c > ============================================================================== > --- head/sys/dev/ixl/if_ixl.c Fri Jan 29 18:43:51 2016 (r295050) > +++ head/sys/dev/ixl/if_ixl.c Fri Jan 29 21:06:59 2016 (r295051) > @@ -674,9 +674,9 @@ ixl_attach(device_t dev) > } > > /* Limit phy interrupts to link and modules failure */ > - error = i40e_aq_set_phy_int_mask(hw, > - I40E_AQ_EVENT_LINK_UPDOWN | I40E_AQ_EVENT_MODULE_QUAL_FAIL, NULL); > - if (error) > + error = i40e_aq_set_phy_int_mask(hw, ~(I40E_AQ_EVENT_LINK_UPDOWN | > + I40E_AQ_EVENT_MODULE_QUAL_FAIL), NULL); > + if (error) > device_printf(dev, "set phy mask failed: %d\n", error); > > /* Get the bus configuration and set the shared code */ >