From owner-freebsd-current@FreeBSD.ORG  Mon Jun  4 07:41:26 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7F1D616A46C;
	Mon,  4 Jun 2007 07:41:26 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe07.swip.net [212.247.154.193])
	by mx1.freebsd.org (Postfix) with ESMTP id BB21713C43E;
	Mon,  4 Jun 2007 07:41:25 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
Received: from [194.248.135.20] (account mc467741@c2i.net HELO laptop.lan)
	by mailfe07.swip.net (CommuniGate Pro SMTP 5.1.7)
	with ESMTPA id 511246893; Mon, 04 Jun 2007 09:41:24 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-current@freebsd.org
Date: Mon, 4 Jun 2007 09:41:16 +0200
User-Agent: KMail/1.9.5
References: <20070601105521.D77697@fledge.watson.org>
	<20070601125901.W92469@fw.reifenberger.com>
	<20070601.131946.71174943.imp@bsdimp.com>
In-Reply-To: <20070601.131946.71174943.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200706040941.16507.hselasky@c2i.net>
Cc: rwatson@freebsd.org, current@freebsd.org, Warner Losh <imp@bsdimp.com>
Subject: Re: NET_NEEDS_GIANT removal
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jun 2007 07:41:26 -0000

On Friday 01 June 2007 21:19, Warner Losh wrote:
> > > i4b		- ISDN implementation
> >
> > ...
> >
> > Before deleting we should replace i4b with the one from hps.
> > http://www.selasky.org/hans_petter/isdn4bsd/index.html
> > It was said to be GIANT free last time I asked.
>
> Who has reviewed this code?  Last time I checked, it had all kinds of
> Byzantine construts that made it extremely difficult to penetrate.
> There were very few comments and it implemented state machines as
> computed gotos :-(.  The cure would be worse than the disease.

When was last time?

The code is constantly changing during the years.

--HPS