From owner-svn-src-all@FreeBSD.ORG Tue Jun 10 17:29:29 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 44875690; Tue, 10 Jun 2014 17:29:29 +0000 (UTC) Received: from i3mail.icecube.wisc.edu (i3mail.icecube.wisc.edu [128.104.255.23]) by mx1.freebsd.org (Postfix) with ESMTP id 179852DEF; Tue, 10 Jun 2014 17:29:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by i3mail.icecube.wisc.edu (Postfix) with ESMTP id 84B1538067; Tue, 10 Jun 2014 12:29:28 -0500 (CDT) X-Virus-Scanned: amavisd-new at icecube.wisc.edu Received: from i3mail.icecube.wisc.edu ([127.0.0.1]) by localhost (i3mail.icecube.wisc.edu [127.0.0.1]) (amavisd-new, port 10030) with ESMTP id 0jLQoyIj_fmq; Tue, 10 Jun 2014 12:29:28 -0500 (CDT) Received: from comporellon.tachypleus.net (polaris.tachypleus.net [75.101.50.44]) by i3mail.icecube.wisc.edu (Postfix) with ESMTPSA id D66BA38063; Tue, 10 Jun 2014 12:29:27 -0500 (CDT) Message-ID: <53974076.9090003@freebsd.org> Date: Tue, 10 Jun 2014 10:29:26 -0700 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Glen Barber Subject: Re: svn commit: r267332 - head/release References: <201406101705.s5AH5gt8007603@svn.freebsd.org> <53973EC7.10306@freebsd.org> <20140610172607.GS1209@hub.FreeBSD.org> In-Reply-To: <20140610172607.GS1209@hub.FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Julio Merino , src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2014 17:29:29 -0000 On 06/10/14 10:26, Glen Barber wrote: > On Tue, Jun 10, 2014 at 10:22:15AM -0700, Nathan Whitehorn wrote: >> On 06/10/14 10:05, Julio Merino wrote: >>> Author: jmmv >>> Date: Tue Jun 10 17:05:41 2014 >>> New Revision: 267332 >>> URL: http://svnweb.freebsd.org/changeset/base/267332 >>> >>> Log: >>> Strip out the test suite from the installation media. >>> This affects the disc1.iso, dvd1.iso and bootonly.iso files. >>> Obtained from: gjb >>> >>> Modified: >>> head/release/Makefile >>> >>> Modified: head/release/Makefile >>> ============================================================================== >>> --- head/release/Makefile Tue Jun 10 17:04:30 2014 (r267331) >>> +++ head/release/Makefile Tue Jun 10 17:05:41 2014 (r267332) >>> @@ -155,7 +155,7 @@ system: packagesystem >>> mkdir -p release >>> cd ${WORLDDIR} && ${IMAKE} installkernel installworld distribution \ >>> DESTDIR=${.OBJDIR}/release WITHOUT_RESCUE=1 WITHOUT_KERNEL_SYMBOLS=1 \ >>> - WITHOUT_PROFILE=1 WITHOUT_SENDMAIL=1 WITHOUT_ATF=1 WITHOUT_LIB32=1 >>> + WITHOUT_PROFILE=1 WITHOUT_SENDMAIL=1 MK_TESTS=no WITHOUT_LIB32=1 >>> # Copy distfiles >> Shouldn't this be "WITHOUT_TESTS" or the like? I thought we weren't supposed >> to set MK_* at the command line. > It does not work, or at least last I tried, because you cannot specify > WITHOUT_FOO=1 if WITH_FOO=1 is set. Using MK_FOO=no allows more > granular tuning for these cases. > > Glen > Ah, OK. Just wanted to make sure it was deliberate! -Nathan