From owner-freebsd-current@FreeBSD.ORG  Sun Dec  5 18:23:51 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C0A5A16A4CE; Sun,  5 Dec 2004 18:23:51 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6A1BE43D54; Sun,  5 Dec 2004 18:23:50 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iB5INlrI064532;
	Sun, 5 Dec 2004 19:23:48 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Tim Kientzle <kientzle@freebsd.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sun, 05 Dec 2004 10:12:29 PST."
             <41B34F8D.5030401@freebsd.org> 
Date: Sun, 05 Dec 2004 19:23:47 +0100
Message-ID: <64531.1102271027@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: Garance A Drosihn <drosih@rpi.edu>
cc: current@freebsd.org
Subject: Re: [TEST/REVIEW]: rootfs mounting code rework 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Dec 2004 18:23:51 -0000

In message <41B34F8D.5030401@freebsd.org>, Tim Kientzle writes:

>> The loader reads /etc/fstab and picks the entry for '/' out of it
>> so I can only pressume that whoever did that disagree with your
>> notion of "correct".
>
>Here's a situation that may be worth thinking
>about:
>
>   * Working FreeBSD system that uses
>     a separate controller.  / is /dev/da4.
>
>   * Controller blows up.
>
>   * Connect hard disk to the on-board controller.
>
>Note: kernel is now being loaded from /dev/da0,
>but /etc/fstab still says / is /dev/da4.
>With the old rootfs code, this system is
>unbootable.
>
>I hope you've considered situations like this.

First: I have _not_ changed the logic that decides _which_ rootfs
to mount, only the mechanics of how it is mounted.

Second: I belive you could simply type something like:

	set vfs.root.mountfrom="ufs:/dev/da0"

in the loader and your system would do what you expect it to.


-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.