From owner-cvs-src@FreeBSD.ORG Wed Apr 16 17:17:48 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 17FBD1065671; Wed, 16 Apr 2008 17:17:48 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpoutm.mac.com (smtpoutm.mac.com [17.148.16.81]) by mx1.freebsd.org (Postfix) with ESMTP id 014E58FC16; Wed, 16 Apr 2008 17:17:47 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from mac.com (asmtp010-s [10.150.69.73]) by smtpoutm.mac.com (Xserve/smtpout018/MantshX 4.0) with ESMTP id m3GHHeNm010201; Wed, 16 Apr 2008 10:17:40 -0700 (PDT) Received: from macbook-pro.jnpr.net (natint3.juniper.net [66.129.224.36]) (authenticated bits=0) by mac.com (Xserve/asmtp010/MantshX 4.0) with ESMTP id m3GHHSFj010151 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Wed, 16 Apr 2008 10:17:33 -0700 (PDT) Message-Id: <5B2C1F89-ADF7-4322-9753-5E7E1A79CD0E@mac.com> From: Marcel Moolenaar To: Rafal Jaworowski In-Reply-To: <4805DE07.8050008@semihalf.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v919.2) Date: Wed, 16 Apr 2008 10:17:28 -0700 References: <200803121601.m2CG1ZbG072258@repoman.freebsd.org> <20080412221501.GB44768@alchemy.franken.de> <4805DE07.8050008@semihalf.com> X-Mailer: Apple Mail (2.919.2) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Marius Strobl Subject: Re: cvs commit: src/sys/boot/common dev_net.c src/sys/boot/uboot/lib console.c copy.c glue.c libuboot.h net.c time.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Apr 2008 17:17:48 -0000 On Apr 16, 2008, at 4:07 AM, Rafal Jaworowski wrote: >> On at least sparc64 reverting this causes ofwn_init() to be called >> over and over again, which doesn't seem to be the right thing to do >> either. > > I think this is expected: the loader/libstand seem to call > devopen()->net_open(), devclose()->net_close() upon each file > access, but it > doesn't seem harmful, only additional output is seen in this case. The additional output is still an eyesore :-) Your change is correct, but it does expose a more fundamental problem with the loader for which we may not have the gumption to fix (as demonstrated by revision 1.7). The bottom-line being that we should not open and close devices wishy-washy. -- Marcel Moolenaar xcllnt@mac.com