From owner-svn-ports-all@FreeBSD.ORG Sat Dec 28 16:43:52 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BAA32E17; Sat, 28 Dec 2013 16:43:52 +0000 (UTC) Received: from mailrelay002.isp.belgacom.be (mailrelay002.isp.belgacom.be [195.238.6.175]) by mx1.freebsd.org (Postfix) with ESMTP id CFE041962; Sat, 28 Dec 2013 16:43:51 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AoUGAGX/vlJbsLLQ/2dsb2JhbABYgws4SblogRQXdIIlAQEBBEcPIxALFAQJJQ8qHgaIGwEIs2KVMBePDBEHhDYEkDOHY4ExkGSDLjs Received: from 208.178-176-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.176.178.208]) by relay.skynet.be with ESMTP; 28 Dec 2013 17:43:42 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id rBSGhgTR029681; Sat, 28 Dec 2013 17:43:42 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Sat, 28 Dec 2013 17:43:41 +0100 From: Tijl Coosemans To: John Marino Subject: Re: svn commit: r337822 - head/math/parmetis Message-ID: <20131228174341.77deb435@kalimero.tijl.coosemans.org> In-Reply-To: <201312272256.rBRMuojP063283@svn.freebsd.org> References: <201312272256.rBRMuojP063283@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/6AES7HZ7WN04gaD8pA6G06j" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Dec 2013 16:43:52 -0000 --MP_/6AES7HZ7WN04gaD8pA6G06j Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On Fri, 27 Dec 2013 22:56:50 +0000 (UTC) John Marino wrote: > Author: marino > Date: Fri Dec 27 22:56:50 2013 > New Revision: 337822 > URL: http://svnweb.freebsd.org/changeset/ports/337822 > > Log: > math/parmetis: Unbreak on FreeBSD 10+ > > ParMetis requires both cmake and gmake. Apparently gmake sets ${MAKE} > to value of "make" if undefined, and this causes the bmake to be launched > for subdirectories rather than gmake. That's the cause of the build > failure for FreeBSD 10+. The eventual fix using MAKE_ARGS took me hours > to figure out, this drove me crazy! gmake does set MAKE correctly. You can test that with a simple Makefile like: all: @echo ${MAKE} The problem is that the code Makefile runs "make -C $(BUILDDIR) $@ $(MAKEFLAGS)". MAKEFLAGS is not meant to be passed on the command line like that because it doesn't contain command line flags. It only contains single letters so "d" instead of "-d". Bmake sets this to "w" when it calls gmake like gmake does for its own submakes to get Entering/Leaving messages. This happens in do-build with USES=gmake. With the attached patch the port still builds for me. --MP_/6AES7HZ7WN04gaD8pA6G06j Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=parmetis.patch Index: Makefile =================================================================== --- Makefile (revision 337860) +++ Makefile (working copy) @@ -22,7 +22,6 @@ OPENMPI_DESC= Use openmpi instead of mpi USES= cmake gmake -MAKE_ARGS+= MAKEFLAGS=MAKE=${GMAKE} PLIST_FILES= include/parmetis/metis.h \ include/parmetis/parmetis.h \ lib/parmetis/libmetis.a \ @@ -47,7 +46,8 @@ MPICC= ${LOCALBASE}/bin/mpicc post-patch: @${REINPLACE_CMD} -e \ 's|BUILDDIR =.*|BUILDDIR = build| ; \ - s|make -C|${MAKE_CMD} -C|' ${WRKSRC}/Makefile + s|make -C|$$(MAKE) -C| ; \ + s|$$(MAKEFLAGS)||' ${WRKSRC}/Makefile @${REINPLACE_CMD} -e \ 's|"-O3"|""|' ${WRKSRC}/metis/GKlib/GKlibSystem.cmake --MP_/6AES7HZ7WN04gaD8pA6G06j--