From owner-svn-ports-all@FreeBSD.ORG  Sat Dec 28 16:56:29 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0C3E4A7;
 Sat, 28 Dec 2013 16:56:29 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id D1B781A02;
 Sat, 28 Dec 2013 16:56:28 +0000 (UTC)
Received: from [192.168.1.113] (c-174-61-88-207.hsd1.fl.comcast.net
 [174.61.88.207])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id D38F4435C7;
 Sat, 28 Dec 2013 10:56:16 -0600 (CST)
Message-ID: <52BF02B0.2050807@marino.st>
Date: Sat, 28 Dec 2013 17:56:16 +0100
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Tijl Coosemans <tijl@FreeBSD.org>
Subject: Re: svn commit: r337822 - head/math/parmetis
References: <201312272256.rBRMuojP063283@svn.freebsd.org>
 <20131228174341.77deb435@kalimero.tijl.coosemans.org>
In-Reply-To: <20131228174341.77deb435@kalimero.tijl.coosemans.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 John Marino <marino@FreeBSD.org>, Brendan Fabeny <bf@FreeBSD.org>,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Dec 2013 16:56:29 -0000

On 12/28/2013 17:43, Tijl Coosemans wrote:
> On Fri, 27 Dec 2013 22:56:50 +0000 (UTC) John Marino wrote:
> 
> gmake does set MAKE correctly.  You can test that with a simple
> Makefile like:
> 
> all:
> 	@echo ${MAKE}
> 
> The problem is that the code Makefile runs "make -C $(BUILDDIR) $@
> $(MAKEFLAGS)".  MAKEFLAGS is not meant to be passed on the command
> line like that because it doesn't contain command line flags.  It only
> contains single letters so "d" instead of "-d".
> Bmake sets this to "w" when it calls gmake like gmake does for its own
> submakes to get Entering/Leaving messages.  This happens in do-build
> with USES=gmake.
> 
> With the attached patch the port still builds for me.

Given that I have spent several hours on this port which isn't even
mine, I'm sick of looking at it.  I didn't find out that ${MAKEFILES}
was the problem until the end.  (I'm also now pretty confused when to
use $(MAKE) and when to use $(MAKE_CMD)).

In any case, this is bf@'s call.  While your patch might be better, I
consider my fix "good enough" since the final result is the same.  I am
CC'ing him, thanks.

John