From owner-freebsd-net Sat Apr 6 17: 6:34 2002 Delivered-To: freebsd-net@freebsd.org Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by hub.freebsd.org (Postfix) with ESMTP id 2BEF937B400 for ; Sat, 6 Apr 2002 17:06:28 -0800 (PST) Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.11.0/8.11.0) id g3716Mj08473; Sat, 6 Apr 2002 17:06:22 -0800 Date: Sat, 6 Apr 2002 17:06:22 -0800 From: Brooks Davis To: Julian Elischer Cc: Brooks Davis , net@FreeBSD.ORG Subject: Re: review request: minor cloning API change Message-ID: <20020406170622.B6096@Odin.AC.HMC.Edu> References: <20020405230719.A13516@Odin.AC.HMC.Edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="cmJC7u66zC7hs+87" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from julian@elischer.org on Sat, Apr 06, 2002 at 04:44:32PM -0800 Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --cmJC7u66zC7hs+87 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 06, 2002 at 04:44:32PM -0800, Julian Elischer wrote: > Please excuse the comment if I'm way off the mark.. >=20 > With a VERY BRIEF look I see that you are returning a void > from the destroy function and it is callled from the module unload code > where some destroy functions used to return ints. >=20 > this ia I think a BAD MOVE.. >=20 > a driver must be able to veto it's own unloading. > If it is in use fro example. You leave no way for the driver to say > "Nope, I can't be unloaded now, I'm busy." NetBSD does it this way and we did so too until a few weeks ago. I'm just returing to the old behavior. The unload of the loopback interface still fails as is required by the system. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --cmJC7u66zC7hs+87 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE8r5uNXY6L6fI4GtQRAsVGAKCusHLJ6YyUmSQn1M673jHdeqOQsACeM8BM TuEM192xapvCTxcGWwjYIuM= =5CML -----END PGP SIGNATURE----- --cmJC7u66zC7hs+87-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message