From owner-cvs-src@FreeBSD.ORG  Thu Oct  9 05:13:58 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2501516A4B3; Thu,  9 Oct 2003 05:13:58 -0700 (PDT)
Received: from gw.celabo.org (gw.celabo.org [208.42.49.153])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id AB14443FCB; Thu,  9 Oct 2003 05:13:56 -0700 (PDT)
	(envelope-from nectar@celabo.org)
Received: from madman.celabo.org (madman.celabo.org [10.0.1.111])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "madman.celabo.org", Issuer "celabo.org CA" (verified OK))
	by gw.celabo.org (Postfix) with ESMTP
	id 6193C54846; Thu,  9 Oct 2003 07:13:56 -0500 (CDT)
Received: by madman.celabo.org (Postfix, from userid 1001)
	id 056206D454; Thu,  9 Oct 2003 07:13:55 -0500 (CDT)
Date: Thu, 9 Oct 2003 07:13:55 -0500
From: "Jacques A. Vidrine" <nectar@FreeBSD.org>
To: Hiten Pandya <hmp@FreeBSD.org>
Message-ID: <20031009121355.GD94235@madman.celabo.org>
References: <200310090945.h999jKns055269@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200310090945.h999jKns055269@repoman.freebsd.org>
X-Url: http://www.celabo.org/
User-Agent: Mutt/1.5.4i-ja.1
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libufs bread.3 cgread.3 getino.3 libufs.3
	sbread.3 ufs_disk_close.3
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Oct 2003 12:13:58 -0000

On Thu, Oct 09, 2003 at 02:45:20AM -0700, Hiten Pandya wrote:
> hmp         2003/10/09 02:45:20 PDT
> 
>   FreeBSD src repository (doc committer)
> 
>   Modified files:
>     lib/libufs           bread.3 cgread.3 getino.3 libufs.3 
>                          sbread.3 ufs_disk_close.3 
>   Log:
>   Remove unneccessary include of sys/types.h in the SYNOPSIS
>   header.
>   
>   Sys/param.h includes sys/types.h internally unless LOCORE is
>   defined.
>   
>   Approved by:    des (mentor)

I think you removed the wrong header.  Is <sys/param.h> required in
each of these cases?  If not, then I believe the synopsis should refer
only to <sys/types.h>:

  (1) Including <sys/types.h> is (by definition) less work than
      <sys/param.h>.

  (2) <sys/types.h> is a POSIX header, while <sys/param.h> is not.

Cheers,
-- 
Jacques Vidrine   . NTT/Verio SME      . FreeBSD UNIX       . Heimdal
nectar@celabo.org . jvidrine@verio.net . nectar@freebsd.org . nectar@kth.se