From owner-svn-src-all@FreeBSD.ORG Fri Jun 13 16:34:50 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7A63AA83 for ; Fri, 13 Jun 2014 16:34:50 +0000 (UTC) Received: from mail-ie0-f175.google.com (mail-ie0-f175.google.com [209.85.223.175]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 43AC02DDE for ; Fri, 13 Jun 2014 16:34:50 +0000 (UTC) Received: by mail-ie0-f175.google.com with SMTP id tp5so2697173ieb.20 for ; Fri, 13 Jun 2014 09:34:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:content-type:mime-version:subject :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=aUQGo7TlPDQ00TnEuFSndpHM8Y5js15uG71QgSSwGlI=; b=OumnqWizOgVOrcwrO+u+uCRZj6ckgANECVRd+CHOAF+Q7RrlrB+SjDzOQynmCo2a24 i9rOQ39DDfSzBbqqla1ZGqRiylBNmu8hF7ukEwEwQquT23YpXgGSPe1SBGNuOk2Tug05 qJzgl76hRvjoMwzcROljIwsJW2wkwi6Rw+RbJdP6MhaYM3N4PfCRyRvDPDxYl91D0mpB +D0kg3BBGzWy5rwXuDB2US8SnxPVXD1OsJ0XWK+PLbBBM7GQ3CwU0zHR7D70h0PS0skT VtISNFF1cR5XI7dg1zvHugoyVW5qHQr07rWClS6V+LzAjYrPTx0uf1TQNSM86mkAbb7n WfFQ== X-Gm-Message-State: ALoCoQm/jGkR5x5dk9Z5K0A/UfdHSkH6/TSqE7SIRzrtsFOBuibq8JD0btbcN98aLZhfjXLXMu5O X-Received: by 10.43.160.4 with SMTP id ma4mr4442331icc.83.1402677289182; Fri, 13 Jun 2014 09:34:49 -0700 (PDT) Received: from [10.0.0.119] (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id b2sm4339516igg.1.2014.06.13.09.34.48 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Jun 2014 09:34:48 -0700 (PDT) Sender: Warner Losh From: Warner Losh X-Google-Original-From: Warner Losh Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Subject: Re: svn commit: r267332 - head/release In-Reply-To: <53973EC7.10306@freebsd.org> Date: Fri, 13 Jun 2014 10:34:50 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201406101705.s5AH5gt8007603@svn.freebsd.org> <53973EC7.10306@freebsd.org> To: Nathan Whitehorn X-Mailer: Apple Mail (2.1878.2) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Julio Merino , src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jun 2014 16:34:50 -0000 On Jun 10, 2014, at 11:22 AM, Nathan Whitehorn = wrote: > On 06/10/14 10:05, Julio Merino wrote: >> Author: jmmv >> Date: Tue Jun 10 17:05:41 2014 >> New Revision: 267332 >> URL: http://svnweb.freebsd.org/changeset/base/267332 >>=20 >> Log: >> Strip out the test suite from the installation media. >> This affects the disc1.iso, dvd1.iso and bootonly.iso files. >> Obtained from: gjb >>=20 >> Modified: >> head/release/Makefile >>=20 >> Modified: head/release/Makefile >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/release/Makefile Tue Jun 10 17:04:30 2014 = (r267331) >> +++ head/release/Makefile Tue Jun 10 17:05:41 2014 = (r267332) >> @@ -155,7 +155,7 @@ system: packagesystem >> mkdir -p release >> cd ${WORLDDIR} && ${IMAKE} installkernel installworld = distribution \ >> DESTDIR=3D${.OBJDIR}/release WITHOUT_RESCUE=3D1 = WITHOUT_KERNEL_SYMBOLS=3D1 \ >> - WITHOUT_PROFILE=3D1 WITHOUT_SENDMAIL=3D1 WITHOUT_ATF=3D1 = WITHOUT_LIB32=3D1 >> + WITHOUT_PROFILE=3D1 WITHOUT_SENDMAIL=3D1 MK_TESTS=3Dno = WITHOUT_LIB32=3D1 >> # Copy distfiles >=20 > Shouldn't this be "WITHOUT_TESTS" or the like? I thought we weren't = supposed to set MK_* at the command line. We recently started allowing MK_TESTS=3Dno on the command line. In = general, all of those WITHOUT_xxx should become MK_xxx=3Dno in = release/Makefile. Having the MK_xxxx version isolates us further from = (a) the current defaults and (b) config files that turn it to the other = direction. Warner