From owner-cvs-all Tue Oct 3 9:43:12 2000 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id D430A37B503; Tue, 3 Oct 2000 09:43:04 -0700 (PDT) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.0/8.11.0) id e93Ggtd64013; Tue, 3 Oct 2000 19:42:55 +0300 (EEST) (envelope-from ru) Date: Tue, 3 Oct 2000 19:42:55 +0300 From: Ruslan Ermilov To: Bill Fumerola Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fw.c Message-ID: <20001003194255.D63113@sunbay.com> Mail-Followup-To: Bill Fumerola , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200010031218.FAA51112@freefall.freebsd.org> <20001003124011.T38472@jade.chc-chimes.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001003124011.T38472@jade.chc-chimes.com>; from billf@chimesnet.com on Tue, Oct 03, 2000 at 12:40:11PM -0400 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, Oct 03, 2000 at 12:40:11PM -0400, Bill Fumerola wrote: > On Tue, Oct 03, 2000 at 05:18:11AM -0700, Ruslan Ermilov wrote: > > > Modified files: > > sys/netinet ip_fw.c > > Log: > > Added the missing ntohs() conversion when matching IP packet with > > the IP_FW_IF_IPID rule. (We have recently decided to keep the > > ip_id field in network byte order inside the kernel, see revision > > 1.140 of src/sys/netinet/ip_input.c). > > Crappy. I haven't been following -current as closely as possible. > This is also true for 4.1.1. > > I did not like to have the conversion happen in userland, and I > > think that the similar conversions for fw_tcp(seq|ack|win) should > > be moved out of userland (src/sbin/ipfw/ipfw.c) into the kernel. > > That's fine, I was just trying to save CPU (perhaps needlessly) by > doing the conversion when we store it as opposed to when we check it. > To save CPU cycles, the conversion could be done in the kernel, when we handle IP_FW_ADD. -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message