From owner-cvs-src@FreeBSD.ORG  Tue Jan 17 16:19:13 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 91D3116A41F;
	Tue, 17 Jan 2006 16:19:13 +0000 (GMT)
	(envelope-from dfr@nlsystems.com)
Received: from mail.qubesoft.com (gate.qubesoft.com [217.169.36.34])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9AD5643D82;
	Tue, 17 Jan 2006 16:19:11 +0000 (GMT)
	(envelope-from dfr@nlsystems.com)
Received: from [10.201.19.245] (doug02.dyn.qubesoft.com [10.201.19.245])
	by mail.qubesoft.com (8.13.3/8.13.3) with ESMTP id k0HGJ872028817;
	Tue, 17 Jan 2006 16:19:08 GMT (envelope-from dfr@nlsystems.com)
In-Reply-To: <200601171111.01942.jhb@freebsd.org>
References: <200512202106.jBKL6hNr035186@repoman.freebsd.org>
	<1CDDC33C-01D5-4AFE-99C0-DE848321D78B@nlsystems.com>
	<200601171111.01942.jhb@freebsd.org>
Mime-Version: 1.0 (Apple Message framework v746.2)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <AFC3FB6C-AEE0-483B-919C-EDCD6DC26EAE@nlsystems.com>
Content-Transfer-Encoding: 7bit
From: Doug Rabson <dfr@nlsystems.com>
Date: Tue, 17 Jan 2006 16:19:07 +0000
To: John Baldwin <jhb@freebsd.org>
X-Mailer: Apple Mail (2.746.2)
X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED autolearn=failed 
	version=3.0.4
X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.qubesoft.com
X-Virus-Scanned: ClamAV 0.86.2/1244/Tue Jan 17 08:46:07 2006 on
	mail.qubesoft.com
X-Virus-Status: Clean
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/pci agp.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jan 2006 16:19:13 -0000


On 17 Jan 2006, at 16:11, John Baldwin wrote:

> On Tuesday 17 January 2006 06:51, Doug Rabson wrote:
>> On 20 Dec 2005, at 21:06, John Baldwin wrote:
>>> jhb         2005-12-20 21:06:43 UTC
>>>
>>>   FreeBSD src repository
>>>
>>>   Modified files:
>>>     sys/pci              agp.c
>>>   Log:
>>>   Change the agp_find_device() to return the first agp device that
>>> has been
>>>   attached to a driver rather than always returning agp0.
>>
>> According to Coverity, this introduces a memory leak
>> (devclass_get_devices() allocates memory).
>
> That it does.  How about this fix:

Looks good to me.