From owner-freebsd-ports@FreeBSD.ORG Wed Feb 8 03:07:08 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB0B7106571F for ; Wed, 8 Feb 2012 03:07:08 +0000 (UTC) (envelope-from sahil@tandon.net) Received: from cricket.hamla.org (cricket.hamla.org [206.251.255.31]) by mx1.freebsd.org (Postfix) with ESMTP id ACEEF8FC14 for ; Wed, 8 Feb 2012 03:07:08 +0000 (UTC) Received: from magic.hamla.org (cpe-68-174-92-20.nyc.res.rr.com [68.174.92.20]) by cricket.hamla.org (Postfix) with ESMTPSA id 06D5B8A038 for ; Tue, 7 Feb 2012 22:07:07 -0500 (EST) Date: Tue, 7 Feb 2012 22:07:06 -0500 From: Sahil Tandon To: freebsd-ports@freebsd.org Message-ID: <20120208030706.GA9104@magic.hamla.org> References: <20120207020427.GB8661@magic.hamla.org> <4831.46.129.107.107.1328625848.squirrel@mymail.acsalaska.net> <0C1FF807-0415-4D21-9C92-C4443BB184CE@tandon.net> <2337.46.129.107.107.1328650051.squirrel@mymail.acsalaska.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2337.46.129.107.107.1328650051.squirrel@mymail.acsalaska.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: clamav-milter 0.97.3 at cricket.hamla.org X-Virus-Status: Clean Subject: Re: Input on "most correct" way to set IS_INTERACTIVE for Postfix ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: freebsd-ports@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Feb 2012 03:07:08 -0000 On Tue, 2012-02-07 at 12:27:31 -0900, rflynn@acsalaska.net wrote: > > On Feb 7, 2012, at 9:44 AM, rflynn@acsalaska.net wrote: > > > >>> mail/postfix and its derivatives are interactive when ALL of the > >>> following conditions are true: > >>> > >>> - PACKAGE_BUILDING is undefined - /etc/mail/mailer.conf exists - > >>> /etc/mail/mailer.conf contains a line beginning with 'purgestat' > >> - POSTFIX_DEFAULT_MTA is unset > > > > Right, but regardless of whether this is set, or what it is set to, > > the script still asks a question unless other conditions are met, > > and only the default answer (that is displayed along with the query) > > is affected. Are you suggesting that we change the behavior to not > > ask the question at all, and just leave mailer.conf alone if the > > latter variable above is unset, and always change mailer.conf if it > > is set? I just want to make sure I understand your suggestion. > > > > Thanks for your input. > > Oh right, BATCH I think, been a while since I looked at it, but this > makes sense to me for the flag in question: > > .ifndef POSTFIX_DEFAULT_MTA IS_INTERACTIVE=yes .endif > > Then if it is set to NO, don't update. If set to YES, do update. > Else be interactive. > > The reason for an explicit NO, is that I'd like to be able to turn it > off and still not be confronted with a question. OK, understood; but this would have to be in conjunction with other logic that checks for the existence of mailer.conf, non-definition of PACKAGE_BUILDING, et cetera -- let me think about this for the next update. In the meantime, I think I will go ahead with a variant of what crees@ suggested, just to provide existing functionality, but reduce the cases in which users find the port marked INTERACTIVE when it really is not, e.g. when upgrading Postfix if /etc/mail/mailer.conf has already been modified by a previous installation. Thank you and everyone else who chimed in on this thread. -- Sahil Tandon