From owner-freebsd-current@FreeBSD.ORG  Mon Jul 19 17:13:07 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 86CEC16A4CE; Mon, 19 Jul 2004 17:13:07 +0000 (GMT)
Received: from carver.gumbysoft.com (carver.gumbysoft.com [66.220.23.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 79E1443D53; Mon, 19 Jul 2004 17:13:07 +0000 (GMT)
	(envelope-from dwhite@gumbysoft.com)
Received: by carver.gumbysoft.com (Postfix, from userid 1000)
	id 612FF72DF2; Mon, 19 Jul 2004 10:13:07 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
	by carver.gumbysoft.com (Postfix) with ESMTP
	id 5C27A72DB5; Mon, 19 Jul 2004 10:13:07 -0700 (PDT)
Date: Mon, 19 Jul 2004 10:13:07 -0700 (PDT)
From: Doug White <dwhite@gumbysoft.com>
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
In-Reply-To: <Pine.BSF.4.53.0407181955250.43309@e0-0.zab2.int.zabbadoz.net>
Message-ID: <20040719100952.H59702@carver.gumbysoft.com>
References: <Pine.BSF.4.53.0407181443330.43309@e0-0.zab2.int.zabbadoz.net>
	<Pine.BSF.4.53.0407181955250.43309@e0-0.zab2.int.zabbadoz.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: FreeBSD current mailing list <freebsd-current@freebsd.org>
Subject: Re: kldunload if_sk -> LOR & panic
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jul 2004 17:13:07 -0000

On Sun, 18 Jul 2004, Bjoern A. Zeeb wrote:

> > At the point where it's actually detaching, once it's detached the methods
> > that access its softc, it should drop its softc lock before calling the
> > network-level detach routines.
>
> I think this is handled by dwhite's patch so I should be safe now.
> Perhaps someone could work towards committing a cleaned up version of
> this patch ?

The LOR is the harmless part.  The panic is caused by
device_delete_child() recursing from skc to sk, and sk_detach() calls
device_delete_child() in itself again after freeing its structures (or
something like that).  My patch should fix this, if not then I have it in
my working sources.

-- 
Doug White                    |  FreeBSD: The Power to Serve
dwhite@gumbysoft.com          |  www.FreeBSD.org