From owner-svn-src-all@FreeBSD.ORG Mon Jun 16 19:05:52 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 114C8342; Mon, 16 Jun 2014 19:05:52 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F2B9E237C; Mon, 16 Jun 2014 19:05:51 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s5GJ5p1n071602; Mon, 16 Jun 2014 19:05:51 GMT (envelope-from trasz@svn.freebsd.org) Received: (from trasz@localhost) by svn.freebsd.org (8.14.8/8.14.8/Submit) id s5GJ5pkS071601; Mon, 16 Jun 2014 19:05:51 GMT (envelope-from trasz@svn.freebsd.org) Message-Id: <201406161905.s5GJ5pkS071601@svn.freebsd.org> From: Edward Tomasz Napierala Date: Mon, 16 Jun 2014 19:05:51 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r267551 - head/sys/cam/ctl X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jun 2014 19:05:52 -0000 Author: trasz Date: Mon Jun 16 19:05:51 2014 New Revision: 267551 URL: http://svnweb.freebsd.org/changeset/base/267551 Log: Add comment explaining a potential problem with just added LUN ID. Reminded by: mav@ Sponsored by: The FreeBSD Foundation Modified: head/sys/cam/ctl/ctl_frontend_iscsi.c Modified: head/sys/cam/ctl/ctl_frontend_iscsi.c ============================================================================== --- head/sys/cam/ctl/ctl_frontend_iscsi.c Mon Jun 16 18:33:32 2014 (r267550) +++ head/sys/cam/ctl/ctl_frontend_iscsi.c Mon Jun 16 19:05:51 2014 (r267551) @@ -2143,6 +2143,10 @@ cfiscsi_devid(struct ctl_scsiio *ctsio, /* * desc1 is for the unique LUN name. + * + * XXX: According to SPC-3, LUN must report the same ID through + * all the ports. The code below, however, reports the + * ID only via iSCSI. */ desc1->proto_codeset = (SCSI_PROTO_ISCSI << 4) | SVPD_ID_CODESET_UTF8; desc1->id_type = SVPD_ID_PIV | SVPD_ID_ASSOC_LUN |