From owner-svn-src-all@FreeBSD.ORG Mon Jun 16 23:09:38 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 610F192E; Mon, 16 Jun 2014 23:09:38 +0000 (UTC) Received: from mail-n.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail-n.franken.de", Issuer "Thawte DV SSL CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 193C628D3; Mon, 16 Jun 2014 23:09:38 +0000 (UTC) Received: from [192.168.1.200] (p508F2AAE.dip0.t-ipconnect.de [80.143.42.174]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTP id A968F1C104939; Tue, 17 Jun 2014 01:09:33 +0200 (CEST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Subject: Re: svn commit: r266083 - in head/sys/arm: arm include From: Michael Tuexen In-Reply-To: <06BB0F4F-44D8-4529-9717-474A137CB60A@freebsd.org> Date: Tue, 17 Jun 2014 01:09:32 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201405141911.s4EJBFZZ097826@svn.freebsd.org> <537D0952.2040001@selasky.org> <7610C8E6-3F01-4317-BC1A-67645A162CD7@FreeBSD.org> <53871493.2010502@selasky.org> <9412A358-EBCB-4A5A-B728-2A15C50FC217@fh-muenster.de> <9B438991-C970-46A7-8116-A490E02D7139@fh-muenster.de> <3841D090-5973-40B0-B61C-F15E8C1978C9@FreeBSD.org> <3664DBD3-7CEA-43E8-9757-E835BB21FE9E@freebsd.org> <5F36DFA5-C5B1-4E5D-88EE-9D60240B40FD@FreeBSD.org> <494BE7DA-26BC-43A7-8BC0-ECAE8A75E1EF@freebsd.org> <6268E444-F6C7-4B8B-86B7-244A2BB3C4DE@FreeBSD.org> <44F7EEB4-46D1-49C7-A4CA-4EA5D41BDF31@freebsd.org> <06BB0F4F-44D8-4529-9717-474A137CB60A@freebsd.org> To: Mark R V Murray X-Mailer: Apple Mail (2.1878.2) Cc: Hans Petter Selasky , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jun 2014 23:09:38 -0000 On 16 Jun 2014, at 22:41, Michael Tuexen wrote: >=20 > On 16 Jun 2014, at 22:13, Mark R V Murray wrote: >=20 >>=20 >> On 16 Jun 2014, at 20:38, Michael Tuexen wrote: >>> Hmm, the documentation reads >>=20 >> Which docs are you using? >>=20 >> I=92m using DDI0360F. (And that could easily be a wrong choice). > That is what I'm also looking at. Selecting ARM1176... >=20 > The code regarding _PMC_USER_READ_WRITE_ also needs to be adopted. > I need to test it... I'll come back in a couple of hours... Using the following updated patch in addition to your patch: Index: cpufunc.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- cpufunc.c (revision 267555) +++ cpufunc.c (working copy) @@ -1409,7 +1409,20 @@ * BEWARE! This gives write access also, which may not be what * you want! */ +#if defined(CPU_ARM1136) || defined(CPU_ARM1176) #ifdef _PMC_USER_READ_WRITE_ + /* Use Secure User and Non-secure Access Validation Control = Register + to allow userland access */ + __asm volatile ("mcr p15, 0, %0, c15, c9, 0\n\t" + : + : "r"(0x00000001)); +#endif + /* Set PMCR[2,0] to enable counters and reset CCNT */ + __asm volatile ("mcr p15, 0, %0, c15, c12, 0\n\t" + : + : "r"(0x00000005)); +#else +#ifdef _PMC_USER_READ_WRITE_ /* Set PMUSERENR[0] to allow userland access */ __asm volatile ("mcr p15, 0, %0, c9, c14, 0\n\t" : @@ -1426,6 +1439,7 @@ : "r"(0xFFFFFFFF), "r"(0x00000005), "r"(0x80000000)); +#endif } #endif allows your test program to run successfully without root privileges, if = I compile the kernel with _PMC_USER_READ_WRITE_ defined. Best regards Michael >=20 > Best regards > Michael=20 >>=20 >> M >> --=20 >> Mark R V Murray >>=20 >>=20 >=20 >=20 >=20