From owner-svn-src-head@FreeBSD.ORG Tue Jun 21 08:31:29 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EAEB41065673; Tue, 21 Jun 2011 08:31:29 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id CDDDC8FC08; Tue, 21 Jun 2011 08:31:29 +0000 (UTC) Received: from delta.delphij.net (c-76-102-50-245.hsd1.ca.comcast.net [76.102.50.245]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 3249EF836; Tue, 21 Jun 2011 01:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1308645089; bh=fHsY/k/qwc1MxLiRTDUIUmnc+lHwADCUcVRB+u3XdSw=; h=Message-ID:Date:From:Reply-To:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=GxGWppQ6a5C38pDOADR3Fg4GkqTO+4asaKuWkF7T5POHRBlyQ8PGk2l8OVmtEVEEg 3E58SSk+T9jFDJCsfbFnYiOLXVmedXpAMfBDxzhxuhbE4d7bxgYep8l8+FOo3uY1XN 619oT6I/de9BcRShY6YZXjXQg6f1ekWVACXsaAtQ= Message-ID: <4E0056E0.2030104@delphij.net> Date: Tue, 21 Jun 2011 01:31:28 -0700 From: Xin LI Organization: The FreeBSD Project MIME-Version: 1.0 To: "Andrey V. Elsukov" References: <201106210446.p5L4k0IZ080002@svn.freebsd.org> <4E00263C.4040802@yandex.ru> <4E00347A.80407@delphij.net> <4E0038F1.3050906@yandex.ru> In-Reply-To: <4E0038F1.3050906@yandex.ru> OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI Subject: Re: svn commit: r223356 - head/sbin/geom/class/part X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2011 08:31:30 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 06/20/11 23:23, Andrey V. Elsukov wrote: > On 21.06.2011 10:04, Xin LI wrote: >>>> Mod the offset padding by alignment. Without this change we may >>>> pad too much when underlying GEOM object have a zero stripesize. >> >>> No. In any way offset value could not be greater than mediasize. >> I don't think this changeset do anything with mediasize? > > I did mean that it could not pad too much. When stripesize is zero the > stripeoffset points to real offset from the beginning of device. > In case when we have nested partitioning schemes like MBR + BSD, > stripeoffset of BSD slice could help align partition to the device. Yes agreed. >>> And it do nothing when alignment value is 1. >> >> No, an alignment value of 1 makes offset = 0, which is the intended >> behavior. >> >> Or did I misunderstood the code? > > The problem that Kris reported was not here. > I think this change is just for the reassurance. Well, I think semantically the offset variable expects a value that represents in-stripe offset rather than the real (against the media) offset that GEOM returns. I'll defer the merge until your change have been merged. Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBCAAGBQJOAFbgAAoJEATO+BI/yjfBNPkH/1HEUxWDuUFoO+4r8FGuTyek 8oFYip67HztN5l8CWiOP61utGPyMLcyk5hS6CwkvAiHaChQeGp75Sp/16D0xkyiT qcJOZIUjtTRvkABrLD/M5vLM5nU3cg80quhPmAjXuPytJFBsy7QdP1cjXK7ql0sB bCXMhqWR8oAbQ5rch8BkFlmRQmHEWFVlR2puxUoBi+YrUEKAiv83ghC9UE4H6NT8 trA+UYr+px2AC+opU0yijdscevdVPdJi6mo08EFqbC6ABzIwTR2Ky2LLhdGrmuk+ impuJz4r44LsKvAxOqFn9bZoBLRTxHMkSju4R8kaAfxT3dehTOK2RViI3FaH7Ko= =jRrp -----END PGP SIGNATURE-----