From owner-cvs-all@FreeBSD.ORG  Mon May 21 18:53:03 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7973116A481;
	Mon, 21 May 2007 18:53:03 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 36E1C13C44C;
	Mon, 21 May 2007 18:53:03 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
Received: from niksun.com (anuket [10.70.0.5])
	by anuket.mj.niksun.com (8.13.6/8.13.6) with ESMTP id l4LIMs6j059473;
	Mon, 21 May 2007 14:22:55 -0400 (EDT)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Doug Barton <dougb@FreeBSD.org>
Date: Mon, 21 May 2007 14:22:44 -0400
User-Agent: KMail/1.6.2
References: <200705211144.l4LBiEHY098477@repoman.freebsd.org>
	<4651E084.1020605@FreeBSD.org>
In-Reply-To: <4651E084.1020605@FreeBSD.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200705211422.47842.jkim@FreeBSD.org>
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	"Ralf S. Engelschall" <rse@FreeBSD.org>, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/etc/rc.d hostid
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 May 2007 18:53:03 -0000

On Monday 21 May 2007 02:10 pm, Doug Barton wrote:
> Ralf S. Engelschall wrote:
> > rse         2007-05-21 11:44:13 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     etc/rc.d             hostid
> >   Log:
> >   Adjust UUID lower-case translation from straight-forward tr(1)
> >   usage to an equivalent csh(1) usage as tr(1) stays in /usr/bin
> > and /etc/rc.d/hostid has just the root filesystem (and this way
> > mainly the tools in /bin) available.
> >
> >   I've chosen csh(1) here as the string manipulation tools
> > available in /bin is extremely limited and the (only) alternative
> > ed(1) usage would have been a lot more complicated or even might
> > require a temporary file.
> >
> >   Revision  Changes    Path
> >   1.4       +2 -1      src/etc/rc.d/hostid
> >
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/hostid.diff?&r
> >1=1.3&r2=1.4&f=h
>
> I really don't like the idea of having an rc.d script depend on
> csh. We don't have any other examples of that, and I don't really
> want to start down that road. I would appreciate it if you'd do a
> little more research into ways that this could be done with the
> tools available.
>
> Meanwhile, I've attached a patch that simplifies the
> hostid_hardware() quite a bit, and has the added virtue of only
> calling csh if it's needed.

Why don't we change smbios.system.uuid to all lower cases? ;-)
I have no problem with that.

Jung-uk Kim