From owner-svn-src-all@FreeBSD.ORG Thu Jun 19 14:07:30 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BF98E77C; Thu, 19 Jun 2014 14:07:30 +0000 (UTC) Received: from mail-qg0-x22b.google.com (mail-qg0-x22b.google.com [IPv6:2607:f8b0:400d:c04::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4EF4F245E; Thu, 19 Jun 2014 14:07:30 +0000 (UTC) Received: by mail-qg0-f43.google.com with SMTP id z60so2152646qgd.16 for ; Thu, 19 Jun 2014 07:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=lqMqB7tvZQ2yyEhx97O0VWHOCjRB6ALCw7xUh70p/HA=; b=lgMsrTgsm7om2FoquEo+wNn7X1AjwwKSmpp18FpPYToik51soXR7Tpkzocga3v/t5T PMha0wyGhpbkcN2q1hNd4CxMER/iuJSgjcCvlNUyG7gCDhf/wI5DG4VA2TTVanwgFQDv M7BukfDlzqLI28JNXQUqamsuwYFSemjXJ3xcrWbIt4/SHIMS6JC/fLguJZnBPAnF5pqA d2oxXc2CQcwCnDABh693/RnO7fTUrzn5HqPWDVmHGYKZDuvn6FWpZ+KPeQJMvA2fhOoz f+JH2sdjStxNFoVhyb27ANcH1W+mwA4ApScZ3+NhFv4n+Q/awuUK7C9cIiIkPE5iwegU UwqQ== MIME-Version: 1.0 X-Received: by 10.140.82.180 with SMTP id h49mr7136013qgd.84.1403186849079; Thu, 19 Jun 2014 07:07:29 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.229.170.195 with HTTP; Thu, 19 Jun 2014 07:07:29 -0700 (PDT) In-Reply-To: <201406190528.s5J5Sg8m099792@svn.freebsd.org> References: <201406190528.s5J5Sg8m099792@svn.freebsd.org> Date: Thu, 19 Jun 2014 07:07:29 -0700 X-Google-Sender-Auth: 3rlofmZsZvk7wj_sn4pWc_lIMtQ Message-ID: Subject: Re: svn commit: r267633 - head/sys/sys From: Matthew Fleming To: Hans Petter Selasky Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jun 2014 14:07:30 -0000 On Wed, Jun 18, 2014 at 10:28 PM, Hans Petter Selasky wrote: > Author: hselasky > Date: Thu Jun 19 05:28:42 2014 > New Revision: 267633 > URL: http://svnweb.freebsd.org/changeset/base/267633 > > Log: > Initialize sysctl OID structure by record. > > MFC after: 2 weeks > > Modified: > head/sys/sys/sysctl.h > > Modified: head/sys/sys/sysctl.h > ============================================================================== > --- head/sys/sys/sysctl.h Thu Jun 19 05:10:03 2014 (r267632) > +++ head/sys/sys/sysctl.h Thu Jun 19 05:28:42 2014 (r267633) > @@ -278,19 +278,16 @@ SYSCTL_ALLOWED_TYPES(UINT64, uint64_t *a > /* This constructs a "raw" MIB oid. */ > #define SYSCTL_OID(parent, nbr, name, kind, a1, a2, handler, fmt, descr)\ > static struct sysctl_oid sysctl__##parent##_##name = { \ > - &sysctl_##parent##_children, \ > - { NULL }, \ > - nbr, \ > - kind, \ > - a1, \ > - a2, \ > - #name, \ > - handler, \ > - fmt, \ > - 0, \ > - 0, \ > - __DESCR(descr) \ > - }; \ > + .oid_parent = &sysctl_##parent##_children, \ > + .oid_number = (nbr), \ > + .oid_kind = (kind), \ > + .oid_arg1 = (a1), \ > + .oid_arg2 = (a2), \ > + .oid_name = #name, \ > + .oid_handler = (handler), \ > + .oid_fmt = (fmt), \ > + .oid_descr = __DESCR(descr) \ > + }; \ > DATA_SET(sysctl_set, sysctl__##parent##_##name) > > #define SYSCTL_ADD_OID(ctx, parent, nbr, name, kind, a1, a2, handler, fmt, descr) \ > C++ kernel modules break with this change, as C++ doesn't have the same syntax for named initializers. Thanks, matthew