From nobody Thu Mar 21 13:31:21 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V0mZK2dRjz5DchC for ; Thu, 21 Mar 2024 13:31:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V0mZK0nGbz4Tdt for ; Thu, 21 Mar 2024 13:31:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711027881; a=rsa-sha256; cv=none; b=GRmpRNCF/sSyV5IIjV26BkS21/C4yssJi4B3ZajUeTqsWcmUNZIGURMDKhZNzgID1UCIYb mo7cEo/jrRfI4aI1HO504aWwEGWsIcTSU55gRovnfLNnbJSZka8XY/i2HZxO6NOKthi/nl btWwG+3mb/hn0sZXAuGFTGcSmPIybirSHQtTQH7HR6Ciry5Z+Et51e0uVMXmH/NIXyL9v7 Eyy0n+gncjnihetHpmCYivEK2i4MfGjfKD5fZg0N03m1LmubcWTrMR27FXuIrbVAzvuOej /CX6dL9YFClV5iYHmc0rS1dXarfRCKVvLs6l1qKoNPRdCGpYgaAPiJMNNFksXw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711027881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NBrNICV1RphOqKX0Ok4b2nc8A8nRSDdqaI9pOXuZfOI=; b=lGJWOh6QgK9WH64gFccdt7GLARf3iP6wcdU9+nFiPsH7jmFP8eTNTWIKLLkDDIRmJyeXV1 NC6m0GhZoybc4WVQoZAh4r0vEZDf8fSPfTQpAEQAXMCiUhFOv9afzjPCfAtMQePnrC57P4 A4rYg8L/Fie/jKuS5UBtyaI6MJ3yvxFVWI6ZTI+V3McIVBKAI7Q554iQsVQ5psKFc9ZBBN lRSqPcO6HWXba3dkQ1YCpYh0OPVkNUDdWKb0bZvDcWq1D9FT5EjkaNQSI3pbfm6IGHpiUp Pyj5nMRgiJezCSdvyTHXAZSGSCrwbrsNZ9OP3Enb2dNaB95cZP9649TObNf0Qg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4V0mZK0PS0zcnJ for ; Thu, 21 Mar 2024 13:31:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 42LDVKfu081376 for ; Thu, 21 Mar 2024 13:31:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 42LDVKU2081369 for bugs@FreeBSD.org; Thu, 21 Mar 2024 13:31:20 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 277862] potential out-of-bounds in llvm-objdump in OffloadBinary::create() Date: Thu, 21 Mar 2024 13:31:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rtm@lcs.mit.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277862 Bug ID: 277862 Summary: potential out-of-bounds in llvm-objdump in OffloadBinary::create() Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: rtm@lcs.mit.edu Created attachment 249370 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D249370&action= =3Dedit broken ELF file that causes llvm-objdump to crash in OffloadBinary::create() In this code in OffloadBinary::create() in llvm-project/llvm/lib/Object/OffloadBinary.cpp: if (... || TheHeader->EntryOffset > TheHeader->Size - sizeof(Entry) || if Size < sizeof(Entry), the subtraction will wrap, and a huge EntryOffset won't be rejected. Then this array reference can generate an out-of-bounds memory reference: const Entry *TheEntry =3D reinterpret_cast(&Start[TheHeader->EntryOffset]); I've attached a demonstration: # freebsd-version 15.0-CURRENT # objdump --version LLVM (http://llvm.org/): LLVM version 17.0.6 Optimized build with assertions. ... # objdump -s objdump1c.exe PLEASE submit a bug report to https://bugs.freebsd.org/submit/ and include = the crash backtrace. Stack dump: 0. Program arguments: objdump -s objdump1c.exe #0 0x0000000001230c41 PrintStackTrace /usr/src/contrib/llvm-project/llvm/lib/Support/Unix/Signals.inc:602:13 #1 0x000000000122f0b5 RunSignalHandlers /usr/src/contrib/llvm-project/llvm/lib/Support/Signals.cpp:105:18 #2 0x0000000001231365 SignalHandler /usr/src/contrib/llvm-project/llvm/lib/Support/Unix/Signals.inc:0:3 #3 0x0000000824b055ff handle_signal /usr/src/lib/libthr/thread/thr_sig.c:0= :3 #4 0x0000000824b04bbb thr_sighandler /usr/src/lib/libthr/thread/thr_sig.c:244:1 #5 0x00000008225332d3 ([vdso]+0x2d3) #6 0x0000000001174709 create /usr/src/contrib/llvm-project/llvm/lib/Object/OffloadBinary.cpp:199:29 #7 0x0000000000f7e328 createBinary /usr/src/contrib/llvm-project/llvm/lib/Object/Binary.cpp:0:12 #8 0x0000000000f7e42a operator bool /usr/src/contrib/llvm-project/llvm/include/llvm/Support/Error.h:559:17 #9 0x0000000000f7e42a createBinary /usr/src/contrib/llvm-project/llvm/lib/Object/Binary.cpp:113:8 #10 0x0000000000e65321 operator bool /usr/src/contrib/llvm-project/llvm/include/llvm/Support/Error.h:559:17 #11 0x0000000000e65321 unwrapOrError, llvm::Strin= gRef &> /usr/src/contrib/llvm-project/llvm/tools/llvm-objdump/llvm-objdump.h:126= :7 #12 0x0000000000e65321 dumpInput /usr/src/contrib/llvm-project/llvm/tools/llvm-objdump/llvm-objdump.cpp:2913= :34 #13 0x0000000000e65321 for_each, std::__1::allocator > *>, void (*)(llvm::StringRef)> /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/__algorithm/for_each.h:= 26:5 #14 0x0000000000e65321 for_each, std::__1::allocator >, std::__1::allocator, std::__1::allocator > > > &, void (*)(llvm::StringRef)> /usr/src/contrib/llvm-project/llvm/include/llvm/ADT/STLExtras.h:1731:10 #15 0x0000000000e65321 main /usr/src/contrib/llvm-project/llvm/tools/llvm-objdump/llvm-objdump.cpp:3248= :3 #16 0x00000008281480aa __libc_start1 /usr/src/lib/libc/csu/libc_start1.c:15= 7:2 Segmentation fault (core dumped) --=20 You are receiving this mail because: You are the assignee for the bug.=