From owner-svn-src-all@FreeBSD.ORG Fri Jun 20 06:13:02 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8B8B1266; Fri, 20 Jun 2014 06:13:02 +0000 (UTC) Received: from mail-we0-x232.google.com (mail-we0-x232.google.com [IPv6:2a00:1450:400c:c03::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D2524291C; Fri, 20 Jun 2014 06:13:01 +0000 (UTC) Received: by mail-we0-f178.google.com with SMTP id x48so3313776wes.9 for ; Thu, 19 Jun 2014 23:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=0l2YYqCnFGTjuKn06/bFeqsusMFta0GbaM9RDtPe8Wk=; b=LesdiTsjrNhqNr6L/nNC2QaWSRm4yDqCq9J0p+R3ct0lHee+z68tEQrxbmYDAZy9ph ok9r++Ab4c+MynjjaJ/VTJdnjVw4bOzMiZIbZ6WMsPdRfADw3CQENZy5jGOKR+pc3tXw 5nALttDQBRm2uRDj4/NWljDekEqVA8QPa5WQhHjNmkFWuT1ogKEyWf7O+Tkk1h+cEzgR kafdXuaodz0ElTje6udwPsnhDsMKDf+tFyjXEYJdp87Y7VvQ65ootazhbc2m+EhRD6aU k5E0BBT1MiExU1wmlxqEO4mJcfTnxrWyI0IQGajEW4j4Z05okn1JGkWhSesZ8538il2s edrA== MIME-Version: 1.0 X-Received: by 10.180.19.233 with SMTP id i9mr1533967wie.38.1403244780040; Thu, 19 Jun 2014 23:13:00 -0700 (PDT) Reply-To: attilio@FreeBSD.org Sender: asmrookie@gmail.com Received: by 10.217.46.129 with HTTP; Thu, 19 Jun 2014 23:12:59 -0700 (PDT) In-Reply-To: <20140620040801.GA3991@kib.kiev.ua> References: <201406192154.s5JLsfed074305@svn.freebsd.org> <20140620040801.GA3991@kib.kiev.ua> Date: Fri, 20 Jun 2014 08:12:59 +0200 X-Google-Sender-Auth: ZuXPqrg04knIaQGZDoL-aeCa580 Message-ID: Subject: Re: svn commit: r267651 - in head: share/man/man4 sys/dev/cpuctl sys/sys usr.sbin/cpucontrol From: Attilio Rao To: Konstantin Belousov Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jun 2014 06:13:02 -0000 On Fri, Jun 20, 2014 at 6:08 AM, Konstantin Belousov wrote: > On Thu, Jun 19, 2014 at 09:54:41PM +0000, Attilio Rao wrote: >> Author: attilio >> Date: Thu Jun 19 21:54:41 2014 >> New Revision: 267651 >> URL: http://svnweb.freebsd.org/changeset/base/267651 >> >> Log: >> Following comments in r242565 add the possibility to specify ecx when >> performing cpuid calls. >> Add also a new way to specify the level type to cpucontrol(8) as >> reported in the manpage. >> >> Sponsored by: EMC / Isilon storage division >> Reviewed by: bdrewery, gcooper >> Testerd by: bdrewery >> Modified: head/sys/sys/cpuctl.h >> ============================================================================== >> --- head/sys/sys/cpuctl.h Thu Jun 19 21:05:07 2014 (r267650) >> +++ head/sys/sys/cpuctl.h Thu Jun 19 21:54:41 2014 (r267651) >> @@ -35,7 +35,8 @@ typedef struct { >> } cpuctl_msr_args_t; >> >> typedef struct { >> - int level; /* CPUID level */ >> + int level; /* CPUID level */ >> + int level_type; /* CPUID level type */ >> uint32_t data[4]; >> } cpuctl_cpuid_args_t; >> >> @@ -50,5 +51,6 @@ typedef struct { >> #define CPUCTL_UPDATE _IOWR('c', 4, cpuctl_update_args_t) >> #define CPUCTL_MSRSBIT _IOWR('c', 5, cpuctl_msr_args_t) >> #define CPUCTL_MSRCBIT _IOWR('c', 6, cpuctl_msr_args_t) >> +#define CPUCTL_CPUID_COUNT _IOWR('c', 7, cpuctl_cpuid_args_t) >> >> #endif /* _CPUCTL_H_ */ > > The cpuctl(4) is used by third-party code, and this change breaks its > ABI. The numeric value for CPUCTL_CPUID is changed, which means that > old binaries call non-existing ioctl now. This is at least a visible > breakage, since the argument for the ioctl changed the layout as well. > > The following patch restored the CPUCTL_CPUID for me. I considered > naming its argument differently, instead of renaming the argument > of CPUCTL_CPUID_COUNT (which you tried to do ?), but decided not, > to preserve the API as well. No, breaking the ABI is fine for -CURRENT so I don't see why we need the bloat. I don't plan on MFC this patch. If I need to (or any user requests that) I will do with the appropriate ABI-compliant way (ie. adding a new argument like this one). Attilio -- Peace can only be achieved by understanding - A. Einstein