From owner-freebsd-emulation@FreeBSD.ORG Fri Jan 20 21:24:40 2006 Return-Path: X-Original-To: freebsd-emulation@freebsd.org Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BA5F16A420 for ; Fri, 20 Jan 2006 21:24:40 +0000 (GMT) (envelope-from nox@saturn.kn-bremen.de) Received: from gwyn.kn-bremen.de (gwyn.kn-bremen.de [212.63.36.242]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8572843D45 for ; Fri, 20 Jan 2006 21:24:38 +0000 (GMT) (envelope-from nox@saturn.kn-bremen.de) Received: from gwyn.kn-bremen.de (gwyn [127.0.0.1]) by gwyn.kn-bremen.de (8.13.4/8.13.4/Debian-3) with ESMTP id k0KLObS1015380; Fri, 20 Jan 2006 22:24:37 +0100 Received: from saturn.kn-bremen.de (uucp@localhost) by gwyn.kn-bremen.de (8.13.4/8.13.4/Submit) with UUCP id k0KLObcJ015378; Fri, 20 Jan 2006 22:24:37 +0100 Received: from saturn.kn-bremen.de (nox@localhost [127.0.0.1]) by saturn.kn-bremen.de (8.13.3/8.13.1) with ESMTP id k0KLJXaE010692; Fri, 20 Jan 2006 22:19:33 +0100 (CET) (envelope-from nox@saturn.kn-bremen.de) Received: (from nox@localhost) by saturn.kn-bremen.de (8.13.3/8.13.1/Submit) id k0KLJXsU010691; Fri, 20 Jan 2006 22:19:33 +0100 (CET) (envelope-from nox) From: Juergen Lock Date: Fri, 20 Jan 2006 22:19:33 +0100 To: NAKATA Maho Message-ID: <20060120211933.GB10503@saturn.kn-bremen.de> Mail-Followup-To: NAKATA Maho , freebsd-emulation@freebsd.org References: <20060118.093740.41689767.chat95@mac.com> <20060119192137.GB13509@saturn.kn-bremen.de> <20060120.105006.85353533.chat95@mac.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060120.105006.85353533.chat95@mac.com> User-Agent: Mutt/1.4.2.1i Cc: freebsd-emulation@freebsd.org Subject: Re: qemu hack X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2006 21:24:40 -0000 On Fri, Jan 20, 2006 at 10:50:06AM +0900, NAKATA Maho wrote: > In Message-ID: <20060119192137.GB13509@saturn.kn-bremen.de> > Juergen Lock wrote: > > > On Wed, Jan 18, 2006 at 09:37:40AM +0900, NAKATA Maho wrote: > > > Dear Juergen and list, > > > I add a hack for qemu port; speed up hack of cirrus vga. > > > http://lists.gnu.org/archive/html/qemu-devel/2006-01/msg00208.html > > > and now qemu seems to be faster a bit. > > > (hope someone can do benchmark) > > > > > > Juergen, can I commit to port? > > > > Well you didnt bump PORTREVISION, also you could call patch with --quiet > Right. According to > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html > > > PORTREVISION should be increased each time a change is made to the port which significantly affects the content or structure of the derived package. > > Changes to MASTER_SITES or other functional changes to the port which do not affect the resulting package. > > My understanding is adding a knob do not affect the resulting packages > since I didn't change anything when installing with `make install' (but > make -DWITH_HACKS install). > > I took this way - since adding unofficial patches are considered as > minor project fork and as you found below, there might be a side effects > as well. IMHO any patch should be upstreamed otherwise > we should fork the project. so I merely added as a knob. > Well, I'm all for the knob, I was just thinking e.g. about someone who has WITH_HACKS in his pkgtools.conf and then portupgrades qemu...