From owner-freebsd-current@FreeBSD.ORG Wed Jun 4 06:14:02 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BAAF11065671; Wed, 4 Jun 2008 06:14:02 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 75D488FC4E; Wed, 4 Jun 2008 06:14:02 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m546BVNm086670; Wed, 4 Jun 2008 00:11:31 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 04 Jun 2008 00:12:53 -0600 (MDT) Message-Id: <20080604.001253.1683325662.imp@bsdimp.com> To: jhb@freebsd.org From: "M. Warner Losh" In-Reply-To: <200805281715.39536.jhb@freebsd.org> References: <200805281715.39536.jhb@freebsd.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: current@freebsd.org Subject: Re: cs(4) MPSAFE patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jun 2008 06:14:02 -0000 In message: <200805281715.39536.jhb@freebsd.org> John Baldwin writes: : I have a patch to make cs(4) MPSAFE. As with previous patches, ENOHARDWARE. : If you care about this driver, test the patch. : : http://www.FreeBSD.org/~jhb/patches/cs.patch This patch appears to work for me, but I've not stress tested the interface. I did have to make a bunch of other changes to the driver to fix some obvious bogons that got in my way. These bogons are in the cs driver, not in your patches to the cs driver. I'm flushing those into svn and looping back the changes plus your patches to make sure things still work. I'll report more when I know more. Note: this is PCMCIA card only (IBM EtherJet Ethernet PC Card). I can confirm that your patch still applies after my changes, although with a fuzz factor. Warner