From owner-cvs-ports@FreeBSD.ORG Tue Aug 31 17:27:09 2010 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD86E10656B9 for ; Tue, 31 Aug 2010 17:27:09 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 5AACA8FC0C for ; Tue, 31 Aug 2010 17:27:08 +0000 (UTC) Received: (qmail 24158 invoked by uid 399); 31 Aug 2010 17:27:08 -0000 Received: from localhost (HELO ?192.168.0.142?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 31 Aug 2010 17:27:08 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4C7D3B6A.5070701@FreeBSD.org> Date: Tue, 31 Aug 2010 10:27:06 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2 MIME-Version: 1.0 To: Martin Matuska References: <201008311011.o7VABx0K050327@repoman.freebsd.org> In-Reply-To: <201008311011.o7VABx0K050327@repoman.freebsd.org> X-Enigmail-Version: 1.2a1pre OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/lighttpd Makefile ports/www/lighttpd/files lighttpd.sh.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2010 17:27:09 -0000 There are a couple of problems with this script, none of them major. First, there are several empty variable assignments, which are neither necessary nor desirable. There are great documentation in the comments, which makes them even less necessary. Second, you have 2 big blocks of code that run unconditionally which we really try to avoid. The deprecated_conf stuff should probably be in a start_precmd method. The lighttpd_instances stuff is harder to call, but it should probably be a start_cmd method. The check_deprecated method should use warn() which has the advantage of also logging the message. Last but not least, run_instance() should use local variables. hth, Doug On 8/31/2010 3:11 AM, Martin Matuska wrote: > mm 2010-08-31 10:11:59 UTC > > FreeBSD ports repository > > Modified files: > www/lighttpd Makefile > www/lighttpd/files lighttpd.sh.in > Log: > - Add multiple instances ability to rc script > > Revision Changes Path > 1.90 +1 -1 ports/www/lighttpd/Makefile > 1.9 +57 -7 ports/www/lighttpd/files/lighttpd.sh.in > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/lighttpd/Makefile.diff?&r1=1.89&r2=1.90&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/lighttpd/files/lighttpd.sh.in.diff?&r1=1.8&r2=1.9&f=h >