From owner-cvs-src@FreeBSD.ORG Tue Aug 19 07:42:26 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B595816A4BF; Tue, 19 Aug 2003 07:42:26 -0700 (PDT) Received: from smtp3.server.rpi.edu (smtp3.server.rpi.edu [128.113.2.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id B3F6443FB1; Tue, 19 Aug 2003 07:42:25 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp3.server.rpi.edu (8.12.9/8.12.9) with ESMTP id h7JEgLmx013538; Tue, 19 Aug 2003 10:42:22 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20030819063934.GC47959@garage.freebsd.pl> References: <200308190353.h7J3r4Fl062425@repoman.freebsd.org> <20030819063934.GC47959@garage.freebsd.pl> Date: Tue, 19 Aug 2003 10:42:20 -0400 To: Pawel Jakub Dawidek From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/newsyslog newsyslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Aug 2003 14:42:27 -0000 At 8:39 AM +0200 8/19/03, Pawel Jakub Dawidek wrote: >On Mon, Aug 18, 2003, Garance A Drosehn wrote: >+> [...] , except that an internal isnumber() routine was >+> removed in favor of the standard library version. The >+> thing is, that internal routine was checking the entire >+> string, and not just the first digit. In OpenBSD, >+> isnumber() was eventually renamed to isnumberstr() to >+> make the distinction more obvious, and I'm going to >+> follow that lead. > >So is is there a chance to put isnumberstr() to libc? Well, OpenBSD did not put isnumberstr() into libc. It is still just a local (to newsyslog.c) routine. I have no plans to put it in libc. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu