From owner-freebsd-bluetooth@FreeBSD.ORG Sun Oct 14 08:18:26 2012 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DF11C787 for ; Sun, 14 Oct 2012 08:18:26 +0000 (UTC) (envelope-from plunky@rya-online.net) Received: from smtpout.wanadoo.co.uk (smtpout3.wanadoo.co.uk [80.12.242.59]) by mx1.freebsd.org (Postfix) with ESMTP id 4EFE48FC08 for ; Sun, 14 Oct 2012 08:18:25 +0000 (UTC) Received: from galant.ukfsn.org ([109.249.238.94]) by mwinf5d37 with ME id AwJP1k00922ti8l03wJPe3; Sun, 14 Oct 2012 10:18:24 +0200 Received: by galant.ukfsn.org (Postfix, from userid 1000) id 25A112600A0; Sun, 14 Oct 2012 09:19:11 +0100 (BST) Date: Sun, 14 Oct 2012 09:19:11 +0100 (BST) From: Iain Hibbert To: Andreas Longwitz Subject: Re: btpand problem In-Reply-To: Message-ID: References: <507736A8.4050605@incore.de> <5077490F.7010901@incore.de> <50782E05.5080005@incore.de> <5079E8F7.5050903@incore.de> User-Agent: Alpine 2.00 (NEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-1863111016-1350202751=:673" Cc: freebsd-bluetooth@freebsd.org X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2012 08:18:26 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-1863111016-1350202751=:673 Content-Type: TEXT/PLAIN; charset=US-ASCII On Sun, 14 Oct 2012, Iain Hibbert wrote: > but, btpand should also ensure that the buffer sizes are suitable. The > server_init() function already does this in FreeBSD, though I also added > some code to increase the RCVBUF size in NetBSD code, and also added (but > didn't yet commit) the similar for client code.. I will prepare a patch patch for btpand attached regards, iain --0-1863111016-1350202751=:673 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=diff Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: ensure buffers are large enough Content-Disposition: attachment; filename=diff SW5kZXg6IGNsaWVudC5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1Mg ZmlsZTogL2hvbWUvbmN2cy9zcmMvdXNyLnNiaW4vYmx1ZXRvb3RoL2J0cGFu ZC9jbGllbnQuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMQ0KZGlmZiAt dSAtcCAtcjEuMSBjbGllbnQuYw0KLS0tIGNsaWVudC5jCTMwIEphbiAyMDA5 IDIyOjIzOjIxIC0wMDAwCTEuMQ0KKysrIGNsaWVudC5jCTE0IE9jdCAyMDEy IDA4OjE1OjUwIC0wMDAwDQpAQCAtNDcsNyArNDcsNyBAQCBjbGllbnRfaW5p dCh2b2lkKQ0KIAlzdHJ1Y3Qgc29ja2FkZHJfbDJjYXAgc2E7DQogCWNoYW5u ZWxfdCAqY2hhbjsNCiAJc29ja2xlbl90IGxlbjsNCi0JaW50IGZkOw0KKwlp bnQgZmQsIG47DQogCXVpbnQxNl90IG1ydSwgbXR1Ow0KIA0KIAlpZiAoYmRh ZGRyX2FueSgmcmVtb3RlX2JkYWRkcikpDQpAQCAtOTcsNiArOTcsMTcgQEAg Y2xpZW50X2luaXQodm9pZCkNCiAJCWV4aXQoRVhJVF9GQUlMVVJFKTsNCiAJ fQ0KIA0KKwlsZW4gPSBzaXplb2Yobik7DQorCWlmIChnZXRzb2Nrb3B0KGZk LCBTT0xfU09DS0VULCBTT19SQ1ZCVUYsICZuLCAmbGVuKSA9PSAtMSkgew0K KwkJbG9nX2VycigiQ291bGQgbm90IHJlYWQgU09fUkNWQlVGIik7DQorCQll eGl0KEVYSVRfRkFJTFVSRSk7DQorCX0NCisJaWYgKG4gPCAobXJ1ICogMTAp KSB7DQorCQluID0gbXJ1ICogMTA7DQorCQlpZiAoc2V0c29ja29wdChmZCwg U09MX1NPQ0tFVCwgU09fUkNWQlVGLCAmbiwgc2l6ZW9mKG4pKSA9PSAtMSkN CisJCQlsb2dfaW5mbygiQ291bGQgbm90IGluY3JlYXNlIFNPX1JDVkJVRiAo ZnJvbSAlZCkiLCBuKTsNCisJfQ0KKw0KIAlsZW4gPSBzaXplb2YobXR1KTsN CiAJaWYgKGdldHNvY2tvcHQoZmQsIFNPTF9MMkNBUCwgU09fTDJDQVBfT01U VSwgJm10dSwgJmxlbikgPT0gLTEpIHsNCiAJCWxvZ19lcnIoIkNvdWxkIG5v dCBnZXQgTDJDQVAgT01UVTogJW0iKTsNCkBAIC0xMDcsNiArMTE4LDI3IEBA IGNsaWVudF9pbml0KHZvaWQpDQogCQlleGl0KEVYSVRfRkFJTFVSRSk7DQog CX0NCiANCisJbGVuID0gc2l6ZW9mKG4pOw0KKwlpZiAoZ2V0c29ja29wdChm ZCwgU09MX1NPQ0tFVCwgU09fU05EQlVGLCAmbiwgJmxlbikgPT0gLTEpIHsN CisJCWxvZ19lcnIoIkNvdWxkIG5vdCBnZXQgc29ja2V0IHNlbmQgYnVmZmVy IHNpemU6ICVtIik7DQorCQljbG9zZShmZCk7DQorCQlyZXR1cm47DQorCX0N CisJaWYgKG4gPCAobXR1ICogMikpIHsNCisJCW4gPSBtdHUgKiAyOw0KKwkJ aWYgKHNldHNvY2tvcHQoZmQsIFNPTF9TT0NLRVQsIFNPX1NOREJVRiwgJm4s IHNpemVvZihuKSkgPT0gLTEpIHsNCisJCQlsb2dfZXJyKCJDb3VsZCBub3Qg c2V0IHNvY2tldCBzZW5kIGJ1ZmZlciBzaXplICglZCk6ICVtIiwgbik7DQor CQkJY2xvc2UoZmQpOw0KKwkJCXJldHVybjsNCisJCX0NCisJfQ0KKwluID0g bXR1Ow0KKwlpZiAoc2V0c29ja29wdChmZCwgU09MX1NPQ0tFVCwgU09fU05E TE9XQVQsICZuLCBzaXplb2YobikpID09IC0xKSB7DQorCQlsb2dfZXJyKCJD b3VsZCBub3Qgc2V0IHNvY2tldCBsb3cgd2F0ZXIgbWFyayAoJWQpOiAlbSIs IG4pOw0KKwkJY2xvc2UoZmQpOw0KKwkJcmV0dXJuOw0KKwl9DQorDQogCWNo YW4gPSBjaGFubmVsX2FsbG9jKCk7DQogCWlmIChjaGFuID09IE5VTEwpDQog CQlleGl0KEVYSVRfRkFJTFVSRSk7DQpJbmRleDogc2VydmVyLmMNCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvaG9tZS9uY3ZzL3NyYy91 c3Iuc2Jpbi9ibHVldG9vdGgvYnRwYW5kL3NlcnZlci5jLHYNCnJldHJpZXZp bmcgcmV2aXNpb24gMS4yDQpkaWZmIC11IC1wIC1yMS4yIHNlcnZlci5jDQot LS0gc2VydmVyLmMJMiBGZWIgMjAwOSAxODowODoyMiAtMDAwMAkxLjINCisr KyBzZXJ2ZXIuYwkxNCBPY3QgMjAxMiAwODoxNTo1MSAtMDAwMA0KQEAgLTE3 Nyw2ICsxNzcsMTggQEAgc2VydmVyX3JlYWQoaW50IHMsIHNob3J0IGV2LCB2 b2lkICphcmcpDQogCQlyZXR1cm47DQogCX0NCiANCisJbGVuID0gc2l6ZW9m KG4pOw0KKwlpZiAoZ2V0c29ja29wdChmZCwgU09MX1NPQ0tFVCwgU09fUkNW QlVGLCAmbiwgJmxlbikgPT0gLTEpIHsNCisJCWxvZ19lcnIoIkNvdWxkIG5v dCByZWFkIFNPX1JDVkJVRiIpOw0KKwkJY2xvc2UoZmQpOw0KKwkJcmV0dXJu Ow0KKwl9DQorCWlmIChuIDwgKG1ydSAqIDEwKSkgew0KKwkJbiA9IG1ydSAq IDEwOw0KKwkJaWYgKHNldHNvY2tvcHQoZmQsIFNPTF9TT0NLRVQsIFNPX1JD VkJVRiwgJm4sIHNpemVvZihuKSkgPT0gLTEpDQorCQkJbG9nX2luZm8oIkNv dWxkIG5vdCBpbmNyZWFzZSBTT19SQ1ZCVUYgKGZyb20gJWQpIiwgbik7DQor CX0NCisNCiAJbGVuID0gc2l6ZW9mKG10dSk7DQogCWlmIChnZXRzb2Nrb3B0 KGZkLCBTT0xfTDJDQVAsIFNPX0wyQ0FQX09NVFUsICZtdHUsICZsZW4pID09 IC0xKSB7DQogCQlsb2dfZXJyKCJDb3VsZCBub3QgZ2V0IEwyQ0FQIE9NVFU6 ICVtIik7DQo= --0-1863111016-1350202751=:673--