From owner-freebsd-current@FreeBSD.ORG Wed Jun 4 07:13:25 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B12B106566B; Wed, 4 Jun 2008 07:13:25 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id E8E0D8FC1F; Wed, 4 Jun 2008 07:13:24 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m547BCcZ087510; Wed, 4 Jun 2008 01:11:12 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 04 Jun 2008 01:12:15 -0600 (MDT) Message-Id: <20080604.011215.1723237511.imp@bsdimp.com> To: jhb@freebsd.org From: "M. Warner Losh" In-Reply-To: <20080604.001253.1683325662.imp@bsdimp.com> References: <200805281715.39536.jhb@freebsd.org> <20080604.001253.1683325662.imp@bsdimp.com> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: current@freebsd.org Subject: Re: cs(4) MPSAFE patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jun 2008 07:13:25 -0000 In message: <20080604.001253.1683325662.imp@bsdimp.com> "M. Warner Losh" writes: : In message: <200805281715.39536.jhb@freebsd.org> : John Baldwin writes: : : I have a patch to make cs(4) MPSAFE. As with previous patches, ENOHARDWARE. : : If you care about this driver, test the patch. : : : : http://www.FreeBSD.org/~jhb/patches/cs.patch : : This patch appears to work for me, but I've not stress tested the : interface. : : I did have to make a bunch of other changes to the driver to fix some : obvious bogons that got in my way. These bogons are in the cs driver, : not in your patches to the cs driver. I'm flushing those into svn and : looping back the changes plus your patches to make sure things still : work. I'll report more when I know more. Note: this is PCMCIA card : only (IBM EtherJet Ethernet PC Card). : : I can confirm that your patch still applies after my changes, although : with a fuzz factor. Upon further testing, I've discovered that the driver neglects to tear down the ISR. http://people.freebsd.org/~imp/cs.patch.new fixes the problem, but may also have some stray goo in it too. Note: I'm only able to test 10BaseT at the moment. 10Base2 is possible with a dongle I have at home, but I have no 10Base2 media. 10Base5 isn't possible for me to test at all. Note 2: Although I have the ISA version of the EtherJet, I don't think I have any ISA machines setup for testing. cs0: at port 0xa100-0xa10f irq 20 function 0 config 1 on pccard0 cs0: CS8920M rev F media TP AUI BNC cs0: failed to enable TP cs0: failed to enable BNC cs0: failed to enable AUI cs0: bpf attached cs0: Ethernet address: 00:20:35:de:f9:4f cs0: [MPSAFE] cs0: [ITHREAD] cs0: detached The failed to enable messages are the same as before. I'm having some problems with my test setup, which means I'm no longer as sure as I was before that I actually passed packets with this card.... But that will have to wait for tomorrow to track down... Warner