From owner-freebsd-ports@FreeBSD.ORG Sat Jan 22 12:54:33 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 51E18106564A for ; Sat, 22 Jan 2011 12:54:33 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id D469F8FC13 for ; Sat, 22 Jan 2011 12:54:32 +0000 (UTC) Received: by bwz12 with SMTP id 12so2431368bwz.13 for ; Sat, 22 Jan 2011 04:54:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=cl4BBghC8St2Cul7iDUYmcp3dHbWnEQgp7PuL78bXak=; b=eH81sPL7PfgjtXjCEMcOm6zR+KC+g+3ceAWi069sVBThs9OgAJfH7DjsK1V+Hun75J ShrBqxkcYeHbR33bfZ/u+e5GYz/cQ8CYxlSa+vIfjqi/U/xcb99Tsbu3pYP51Xpnohn6 p8+Q8My2ZOryCnmYJs9qqrpM2gqc9MgBxuK6c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; b=PFdXHYrbvJrTsVG2WhyNYFmIA6o6O+07q0E3yuIJyrIbcE94eFqjRrNNprjxu7aY/z U/m1FXnHD1Yi4d5JyoXx1SiOdLGtAZ8n3WD38EgB+EccDuoq50Zz40OywdNDFM8+qRPy tyR52nnzEBVC51d0bjBtfka0Xb+QTO/Id7Al4= Received: by 10.204.46.134 with SMTP id j6mr1752688bkf.112.1295700869330; Sat, 22 Jan 2011 04:54:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.52.19 with HTTP; Sat, 22 Jan 2011 04:53:59 -0800 (PST) In-Reply-To: <4D39FEBA.3000806@janh.de> References: <4D39FEBA.3000806@janh.de> From: Chris Rees Date: Sat, 22 Jan 2011 12:53:59 +0000 Message-ID: To: Jan Henrik Sylvester Content-Type: text/plain; charset=ISO-8859-1 Cc: ports-list freebsd Subject: Re: Xournal: Please, help me with my first port X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: utisoft@gmail.com List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Jan 2011 12:54:33 -0000 On 21 January 2011 21:46, Jan Henrik Sylvester wrote: > Finally, I found an application worse having that is not in ports and looked > simple enough to try: Xournal is my first attempt to create a new port. > > I followed the handbook and did the basic testing with porttools: There are > warnings about considering to use DATADIR if the port was DATADIR-safe, but > I do not assume it to be. > > Moreover, there is a warning about my post-patch line. I think the warning > is wrong, but I am unsure about that line anyhow. The desktop-install target > in Makefile.in is wrong for FreeBSD, but there is probably a better way to > fix it. > > Is my attempt to use the desktop-install target via post-install correct? > > Do all the files installed by the post-install target go to the correct > locations? > > Is there anything else I should fix before submitting the port as pr? > > In case the attachment does not make it to the list, I have placed a copy > here: http://www.math.uni-hamburg.de/home/sylvester/xournal.shar > The DATADIR whines are addressed in this patch, have a look: http://www.bayofrum.net/~chris/patches/xournal-pkg-plist.diff That's all I had time to look at at the moment, perhaps others can help! Chris