From owner-svn-src-all@FreeBSD.ORG Mon Jun 23 22:33:21 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E889D5C9; Mon, 23 Jun 2014 22:33:20 +0000 (UTC) Received: from mail-we0-x232.google.com (mail-we0-x232.google.com [IPv6:2a00:1450:400c:c03::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E12002CAB; Mon, 23 Jun 2014 22:33:19 +0000 (UTC) Received: by mail-we0-f178.google.com with SMTP id x48so7941685wes.9 for ; Mon, 23 Jun 2014 15:33:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=6O+vWC4+Kqo6DGXES1u7qAoqkYSBXF6wVs50GN76oEo=; b=aiL8PC5xUz0M7/P3Pz/3HXF559mAFY+nia2ry96slYeHHfblstYvKaJYt5gbqNKf6e cHXjQ0KiXyhkB63gWQUdf/GZhhbK0BC7kRymUsGtBIVlEM0MtoFkBOIN08yzLjDoaBvF VFr1O+vq+BUu6qqNzy8FDDd56zfyEmc67tZmDpJXBgZzYsNB6CEAW5TSM+N6nW1RehlB aTY6lkSyqIQnEKv21fKvdCnF2+eqmhfPLobIAFq9buuevzVmtcbzAYzwUaQaFdOlOc9Q +kmfrG8Coi4KQA+kbYEFg2P+7LRuX5hwhPc2r9XcWt2k96eNSAd51wMuZALmYjtzt1fT xG+Q== X-Received: by 10.194.238.134 with SMTP id vk6mr31435307wjc.93.1403562797997; Mon, 23 Jun 2014 15:33:17 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPSA id jv9sm39142241wjc.28.2014.06.23.15.33.16 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 23 Jun 2014 15:33:17 -0700 (PDT) Date: Tue, 24 Jun 2014 00:33:14 +0200 From: Mateusz Guzik To: Craig Rodrigues Subject: Re: svn commit: r267807 - in stable/10: sbin/mount_nullfs sys/x86/acpica Message-ID: <20140623223314.GA15832@dft-labs.eu> References: <201406232231.s5NMVS4d092409@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201406232231.s5NMVS4d092409@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-10@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jun 2014 22:33:21 -0000 On Mon, Jun 23, 2014 at 10:31:28PM +0000, Craig Rodrigues wrote: > Author: rodrigc > Date: Mon Jun 23 22:31:28 2014 > New Revision: 267807 > URL: http://svnweb.freebsd.org/changeset/base/267807 > > Log: > MFC r263795: > > Strict value checking will cause problem. > Bay trail DN2820FYKH is supported on Linux but does not work on FreeBSD. > This behaviour is bug-compatible with Linux-3.13.5. > > References: > http://d.hatena.ne.jp/syuu1228/20140326 > http://lxr.linux.no/linux+v3.13.5/arch/x86/kernel/acpi/boot.c#L1094 > > Submitted by: syuu > PR: 187966 > > Modified: > stable/10/sbin/mount_nullfs/mount_nullfs.c > stable/10/sys/x86/acpica/madt.c > Directory Properties: > stable/10/ (props changed) > > Modified: stable/10/sbin/mount_nullfs/mount_nullfs.c > ============================================================================== > --- stable/10/sbin/mount_nullfs/mount_nullfs.c Mon Jun 23 19:47:25 2014 (r267806) > +++ stable/10/sbin/mount_nullfs/mount_nullfs.c Mon Jun 23 22:31:28 2014 (r267807) > @@ -103,18 +103,25 @@ main(int argc, char *argv[]) > err(EX_USAGE, "%s", source); > > if (subdir(target, source) || subdir(source, target)) > - errx(EX_USAGE, "%s (%s) and %s are not distinct paths", > + errx(EX_USAGE, "%s (%s) and %s are not lldistinct paths", > argv[0], target, argv[1]); > > + printf("Debug: 1\n"); > build_iovec(&iov, &iovlen, "fstype", nullfs, (size_t)-1); > build_iovec(&iov, &iovlen, "fspath", source, (size_t)-1); > build_iovec(&iov, &iovlen, "target", target, (size_t)-1); > build_iovec(&iov, &iovlen, "errmsg", errmsg, sizeof(errmsg)); > + printf("Debug: 2, source: %zd target: %zdd\n", strlen(source), strlen(target)); > if (nmount(iov, iovlen, 0) < 0) { > - if (errmsg[0] != 0) > + printf("Debug: 3\n"); > + if (errmsg[0] != 0) { > + printf("Debug 4\n"); > err(1, "%s: %s", source, errmsg); > - else > + } > + else { > + printf("Debug 5\n"); > err(1, "%s", source); > + } > } > exit(0); > } > Does not look intended. :> -- Mateusz Guzik