From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Aug 24 18:46:17 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0DA03119 for ; Sun, 24 Aug 2014 18:46:17 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E2EE538D4 for ; Sun, 24 Aug 2014 18:46:16 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s7OIkGUk017128 for ; Sun, 24 Aug 2014 18:46:16 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 192964] [New Port] devel/go-hashicorp-logutils Date: Sun, 24 Aug 2014 18:46:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: thomas@bartelmess.io X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Aug 2014 18:46:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192964 --- Comment #7 from Thomas Bartelmess --- I think the @dirrmtry %%GO_SRCDIR%%/%%GO_PKGNAME%% @dirrmtry %%GO_SRCDIR%%/github.com/hashicorp @dirrmtry %%GO_SRCDIR%%/github.com @dirrmtry %%GO_SRCDIR%% @dirrmtry %%GO_LIBDIR%%/github.com/hashicorp @dirrmtry %%GO_LIBDIR%%/github.com @dirrmtry %%GO_LIBDIR%% @dirrmtry share/go/pkg @dirrmtry share/go is still required since go installs the sources of the package there. (In reply to John Marino from comment #5) > (In reply to Thomas Bartelmess from comment #4) > > For me it seems like > > bsd.port.pre.mk has to be included before bsd.go.mk > > If it's not included, I am getting an error, because the $ARCH variable is > > not set > > > > WARNING (devel/go-hashicorp-logutils): make: > > "/usr/ports/devel/go-hashicorp-logutils/../../lang/go/files/bsd.go.mk" line > > 20: Malformed conditional (${ARCH} == "i386") > > WARNING (devel/go-hashicorp-logutils): make: Fatal errors encountered -- > > cannot continue > > > crap, bsd.go.mk is what needs it. > > > > > > > > Is there a reason why > > > > .include "${.CURDIR}/../../lang/go/files/bsd.go.mk" > > > > if preferred over > > .include "${PORTSDIR}/lang/go/files/bsd.go.mk" > > > One good reason is that it eliminates the need for 
 and 
> normally.  A second reason is that the absolute path fails in some use
> cases, relative paths never fail.
> 
> Still make this relative patch, but leave 
/ with a "#" comment
> saying that bsd.go.mk has $ARCH requiring 
 inclusion first.

(In reply to John Marino from comment #3)
> 1) you can just past portlint output in comment, we don't need attachment
> for that
> 
> 2) when you attach a shar, set mime = text/plain
> 
> 3) You tabbed too much, everything except PORTVERSION
> 
> 4) you did this again:
> 
> X.include 
> X.include "${PORTSDIR}/lang/go/files/bsd.go.mk"
> X.include 
> 
> 5) see this?
> 
> X@dirrmtry %%GO_SRCDIR%%/%%GO_PKGNAME%%
> X@dirrmtry %%GO_SRCDIR%%/github.com/hashicorp
> X@dirrmtry %%GO_SRCDIR%%/github.com
> X@dirrmtry %%GO_SRCDIR%%
> X@dirrmtry %%GO_LIBDIR%%/github.com/hashicorp
> X@dirrmtry %%GO_LIBDIR%%/github.com
> X@dirrmtry %%GO_LIBDIR%%
> X@dirrmtry share/go/pkg
> X@dirrmtry share/go
> 
> I think only the first one is needed; the rest probably belong to go.  And
> the first one should be @dirrm, not @dirrmtry.  Never use @dirrmtry if
> @dirrm is guaranteed to work.
> 
> Please update the shar.

-- 
You are receiving this mail because:
You are the assignee for the bug.