From owner-svn-src-all@FreeBSD.ORG Wed Jun 25 13:29:36 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 33A8234C; Wed, 25 Jun 2014 13:29:36 +0000 (UTC) Received: from mail-wg0-x234.google.com (mail-wg0-x234.google.com [IPv6:2a00:1450:400c:c00::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2AFF927CD; Wed, 25 Jun 2014 13:29:35 +0000 (UTC) Received: by mail-wg0-f52.google.com with SMTP id b13so2034611wgh.11 for ; Wed, 25 Jun 2014 06:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Xtq82Q8wlIsQ8GbRL1ma6/qu6Zktu3J8n1mhI3FzzWI=; b=jG8NeXXLxAZll+/hrtWA4D3Mo7EnO/loWiGx5K4pAePzbsaIIJiE6+k81hbFBFx6dR Q8cu5XOFPS3852Yps42ZoA5lY1Uz0w9IKpsUx2L9LkOycier52hBiRgi0iUSg+qHTN8C EYJrfpXsuIkuVykalewlU0//GUwxibn/gbTbNwtu1KHSv4BSqQinnObiKCFnBhK+nZEB 92tWBEdsnSCw15BpBQY6ZqSPDhmN/X2EMB2GwO9klKYR/vjX8QuI8a+egFwbOLM7DR7M s/3ELV8ZBijWN6LvolHjjEFuNoBmGIdUN4fBhRlJ8T11aTn789XHFoPeBl91xYkda/Nm x2sA== X-Received: by 10.180.107.99 with SMTP id hb3mr10533243wib.8.1403702969713; Wed, 25 Jun 2014 06:29:29 -0700 (PDT) Received: from [172.16.1.30] (39.Red-2-136-52.dynamicIP.rima-tde.net. [2.136.52.39]) by mx.google.com with ESMTPSA id r9sm53803276wia.17.2014.06.25.06.29.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 25 Jun 2014 06:29:28 -0700 (PDT) Sender: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Message-ID: <53AACEAB.3090702@FreeBSD.org> Date: Wed, 25 Jun 2014 15:29:15 +0200 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: attilio@FreeBSD.org, Alan Cox Subject: Re: svn commit: r267858 - in head/sys/dev: virtio/balloon xen/balloon References: <201406250951.s5P9p8YR017159@svn.freebsd.org> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jun 2014 13:29:36 -0000 On 25/06/14 13:58, Attilio Rao wrote: > On Wed, Jun 25, 2014 at 11:51 AM, Roger Pau Monné wrote: >> Author: royger >> Date: Wed Jun 25 09:51:08 2014 >> New Revision: 267858 >> URL: http://svnweb.freebsd.org/changeset/base/267858 >> >> Log: >> xen/virtio: fix balloon drivers to not mark pages as WIRED >> >> Prevent the Xen and VirtIO balloon drivers from marking pages as >> wired. This prevents them from increasing the system wired page count, >> which can lead to mlock failing because of hitting the limit in >> vm.max_wired. > > This change is conceptually wrong. > The pages balloon is allocating are unmanaged and they should be wired > by definition. Alan and I are considering enforcing this (mandatory > wired pages for unmanaged pages allocation) directly in the KPI. > This in practice just seem an artifact to deal with scarce wired > memory limit. I suggest that for the XEN case this limit gets bumped > rather relying on similar type of hacks. IMHO, marking them as wired seems wrong too, those pages are not wired, they are simply not there any more. This was discussed in: http://lists.freebsd.org/pipermail/freebsd-virtualization/2014-June/002643.html If there's consensus I will revert the change, but I would say that increasing vm.max_wired for VMs is also a gross hack. Roger.