From owner-cvs-src@FreeBSD.ORG  Tue Jan 17 20:25:02 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0E14D16A41F;
	Tue, 17 Jan 2006 20:25:02 +0000 (GMT)
	(envelope-from jmallett@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B963F43D45;
	Tue, 17 Jan 2006 20:25:01 +0000 (GMT)
	(envelope-from jmallett@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k0HKP1Zt063548;
	Tue, 17 Jan 2006 20:25:01 GMT
	(envelope-from jmallett@repoman.freebsd.org)
Received: (from jmallett@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k0HKP1EW063539;
	Tue, 17 Jan 2006 20:25:01 GMT (envelope-from jmallett)
Message-Id: <200601172025.k0HKP1EW063539@repoman.freebsd.org>
From: Juli Mallett <jmallett@FreeBSD.org>
Date: Tue, 17 Jan 2006 20:25:01 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/kern kern_proc.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jan 2006 20:25:02 -0000

jmallett    2006-01-17 20:25:01 UTC

  FreeBSD src repository

  Modified files:
    sys/kern             kern_proc.c 
  Log:
  Since p_cansee will end up dereferencing p_ucred, don't check for p_ucred
  equal to NULL several times later.  p_ucred "should probably not" be NULL
  if the process isn't PRS_NEW anyway.  This is strongly reinforced by the fact
  that we don't see frequent crashes here.  Remove the checks after p_cansee and
  add a KASSERT right before it.
  
  Found by:       Coverity Prevent (tm)
  
  Also trim one nearby trailing space.
  
  Revision  Changes    Path
  1.237     +7 -9      src/sys/kern/kern_proc.c