From owner-p4-projects@FreeBSD.ORG  Tue Jul 18 19:22:34 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D595416A4E6; Tue, 18 Jul 2006 19:22:33 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B108116A4DE;
	Tue, 18 Jul 2006 19:22:33 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8743B43D49;
	Tue, 18 Jul 2006 19:22:32 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k6IJMTOu055737;
	Tue, 18 Jul 2006 15:22:31 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Paolo Pisati <piso@freebsd.org>
Date: Tue, 18 Jul 2006 15:18:12 -0400
User-Agent: KMail/1.9.1
References: <200607181107.k6IB7Vf1040641@repoman.freebsd.org>
In-Reply-To: <200607181107.k6IB7Vf1040641@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200607181518.12791.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Tue, 18 Jul 2006 15:22:31 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.87.1/1604/Tue Jul 18 11:41:03 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 
	autolearn=ham version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 101845 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jul 2006 19:22:34 -0000

On Tuesday 18 July 2006 07:07, Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=101845
> 
> Change 101845 by piso@piso_newluxor on 2006/07/18 11:07:29
> 
> 	Defining an interrupt handler as INTR_FAST means 
> 	the interrupt thread associated to this interrupt event
> 	won't be created: actually with filter+ithread, we need
> 	that thread.

The real fix is to stop checking INTR_FAST and to create an ithread as long as 
at least one interrupt handler (struct intr_handler) has a threaded handler 
(ih_handler != NULL).

> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/dev/em/if_em.c#7 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2006/intr_filter/dev/em/if_em.c#7 (text+ko) ====
> 
> @@ -1986,7 +1986,7 @@
>  	 */
>  	TASK_INIT(&sc->link_task, 0, em_handle_link, sc);
>  	if ((error = bus_setup_intr(dev, sc->res_interrupt,
> -	    INTR_TYPE_NET | INTR_FAST, em_intr_fast, em_handle_rxtx, sc,
> +	    INTR_TYPE_NET, em_intr_fast, em_handle_rxtx, sc,
>  	    &sc->int_handler_tag)) != 0) {
>  		device_printf(dev, "Failed to register fast interrupt "
>  			    "handler: %d\n", error);
> 

-- 
John Baldwin