From owner-freebsd-ports@FreeBSD.ORG Fri Dec 28 20:50:30 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 030AAEF9 for ; Fri, 28 Dec 2012 20:50:30 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-la0-f50.google.com (mail-la0-f50.google.com [209.85.215.50]) by mx1.freebsd.org (Postfix) with ESMTP id 6B7358FC12 for ; Fri, 28 Dec 2012 20:50:29 +0000 (UTC) Received: by mail-la0-f50.google.com with SMTP id fs13so1365644lab.23 for ; Fri, 28 Dec 2012 12:50:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=am9wBW3xtzMflluOVuOPjs4UsLkMWYU4br0ehu7rCcU=; b=bnFToChZfin48gjjsfwvCIds2FByWg4FALZon4qJ12RZ3zXtPueOcbSf42fkM47oL+ Ku/ChgXDVKizjJDDGvrfs5h5hfOadUKmCR3fB98ALIvZi3knnDeU6w7q6ZbNOPRV9onc O43hw4xBNZj9zhT2znWMg9wkTfTS3PVeN35VA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=am9wBW3xtzMflluOVuOPjs4UsLkMWYU4br0ehu7rCcU=; b=hyPtM+QTvtaRCEpsbB5WFLwnyfE6hIEyKy7EYuyfZ6MsVuNwpqd07Oee/a9kkW8IbM GMyOEnef7z+HdJLncOPHmMR1Lfht8Xup5K4raCo0Q4r65DM9Hfd59wKwz9dCiKhhfjJc WnZD2KIEIUHIGF2TEr3p9maqmAVTqZj0TyVJT+8ItUq56SKPzfjqswzujCU3Vz6S/oEC sxWjYkMAymjPsbCAjHJLLReTY+dH+jfZQRxCi4ffqYBluNJ43yAzNbJmwSCnnwYbm9/K Ohn53WmYIQv6vBchaPbVyNXYoj36RhER+sm/CQYPvutb9ntMaPbTawK4e8tAodWo1qbb 0RLQ== Received: by 10.112.25.198 with SMTP id e6mr14116169lbg.63.1356727828010; Fri, 28 Dec 2012 12:50:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.87.102 with HTTP; Fri, 28 Dec 2012 12:49:56 -0800 (PST) In-Reply-To: <20121228202457.GA80033@misty.eyesbeyond.com> References: <20121228202457.GA80033@misty.eyesbeyond.com> From: Eitan Adler Date: Fri, 28 Dec 2012 15:49:56 -0500 Message-ID: Subject: Re: java/openjdk6 fails to build.. To: Greg Lewis Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQkKcnsKC8hcgFzpnVGR33tm+FWuoc/OJQmlcjtS7fqOR7r0zUlUd6V3cOqHKxUxvDgz/n9e Cc: David Demelier , java@freebsd.org, freebsd-ports@freebsd.org, Ronald Klop X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2012 20:50:30 -0000 On 28 December 2012 15:24, Greg Lewis wrote: > On Fri, Dec 21, 2012 at 07:27:22PM -0500, Eitan Adler wrote: >> On 21 December 2012 19:16, David Demelier wrote: >> > Yes, I wanted to answser, but the man says that MAKE_JOBS are disabled by >> > default, I tried to build with MAKE_JOBS=1 and it works, the problem did >> > appear when MAKE_JOBS=6 was set. Can you reproduce the issue? >> >> I want to mark this MAKE_JOBS_UNSAFE=yes and remove the current hack >> Any objection from java@ ? >> >> > I had MAKE_JOBS=6 in my /etc/make.conf instead of MAKE_JOBS_NUMBER though >> >> Exactly. MAKE_JOBS is not user-settable. MAKE_JOBS_NUMBER is. IMHO >> MAKE_JOBS should start with an _. > > I think that's right. I have no objection. I think whats in openjdk7 > is closer to what it should be. What is in openjdk7 seems bogus and it isn't clear why it is there: MAKE_JOBS_UNSAFE= yes is defined implying that MAKE_JOBS should always be 1 (and -j never set) but it does some weird things with the global variables MAKE_JOBS_NUMBER and DISABLE_MAKE_JOBS. Can the generic handling in b.p.m not work? IMHO MAKE_JOBS_SAFE=yes should be defined and either b.p.m or b.java.m should be handling the special build code. -- Eitan Adler