From owner-svn-src-all@FreeBSD.ORG Thu Jun 26 08:21:33 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 90D07A78 for ; Thu, 26 Jun 2014 08:21:33 +0000 (UTC) Received: from nm34-vm7.bullet.mail.bf1.yahoo.com (nm34-vm7.bullet.mail.bf1.yahoo.com [72.30.239.79]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3E6FF2C31 for ; Thu, 26 Jun 2014 08:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1403770570; bh=QK4XT7zVVczPbYg+gJ1QzlVQY6+bOXhGxo4llT7Xlis=; h=Received:Received:Received:X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Message-Id:References:To:X-Mailer; b=Ep9xS4PP5dtiQhY61S0n33UJWCwtDZpiaiWt7rRazjWPPb8usDxJytqbIboYZXZ+/rl5gCk0/Jgp185NocIX2a7aooFyscg66eOvv/M7OIVBM1Fvj9LbpZbmVZlm1U2qJydVfJVg1f8Ahr05Bf1DSJIQclSxl/4YbDF5+OotxPG+EtE0WRWyP6TpKps4K0E4dQjXPinNjZlDpUDff2S9thP2Un+rHgwLy+HA4UPH7Lw087h2mU45ey2TLtM9sYeYSdwhFfNAkXPhT0sMqNHDbWrsMjDDDIBz6J1UQin+UwsKNfxKP4gr5ALk6q5IkHnIS4JbAoX5jknO93cuOBvdrA== DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s2048; d=yahoo.com; b=VKWKI35Yww+zQVQF0BZOGoFZfn2BvAEprC7Xp8whFrHDDxpLUebtP8PZBqSLKjKEsngltbUvFexCMLv6YQSJbZV7sWUaboFBKzZPSXRz2sWXD2OrdH3bsv+lu6EXApdRI9wqhU89JmRjOovVUrBbAWN2n6Mcmn2nEhPzNDr3/ApuB86uwYpJbQeuJ6FgHLEHYMqw/8ftoM+GZb2ZbFwvQXnKgRDaouPO9I0U0noAd5igXXAk+LFwVKkEsUpLIXf6uTfX2dp2EkOZVgT8NKoDL/uzsoKHvlj0NkImYuDguuTa/iJnQxknflcqy9UMRA8+gu2KrlwSdJNbeEiRsnQT1w==; Received: from [66.196.81.171] by nm34.bullet.mail.bf1.yahoo.com with NNFMP; 26 Jun 2014 08:16:10 -0000 Received: from [98.139.213.9] by tm17.bullet.mail.bf1.yahoo.com with NNFMP; 26 Jun 2014 08:16:10 -0000 Received: from [127.0.0.1] by smtp109.mail.bf1.yahoo.com with NNFMP; 26 Jun 2014 08:16:10 -0000 X-Yahoo-Newman-Id: 85838.10776.bm@smtp109.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: HD73J84VM1kPvwqUOiNwZ0a3kQRLNwSi68gcSsKy9au7ARv dPj_Ccp9cMh2ONFJzR3TXqN0d8d9w58eXqU3F1xSGFkVoolTADk8kHhd5E93 V8_LKZjWkLhKZsg3heqdCxs6bCTQcXmE5aeGenmK1.JKVYay_9aPhUaF19eD OdMj5ECuy2bfq4.uOrWkOdOfTlP4IleOd_FHgSFakLIHu9I1ZIQVG_4JJRzh HjArng1aUCEhy4KFZY5hfHUWeaCn.g6dttFvrZQwtLgNZP3oXYjfoMQhQAzF lkhnLZj9CDUvWmJhD1zYqhIhvHf04RDwZp8rEb7g_dZR3kaTGOEs6Y7fVEMD RsZRj8Ses2DHs2oBjYQOgKs1uWKPSzQI9YyVPb76y4DyKtkp9ITGgYwvQlZp 7vK712uL9QTXFz4XqM7sJGBLEpFX_w_8ZS5CM.vgSmspFCid3fAiVVUwFGzn k_tDoQ3BcBPSc5GEBazNuJGZhRmcRbvMSr0LfSzjj7haOCOfCMWwgccBdDn6 18ovdwL9RX_l0B7T6ANFMxm96JmfY1JM- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf X-Rocket-Received: from [192.168.0.101] (pfg@190.157.126.109 with plain [98.138.105.21]) by smtp109.mail.bf1.yahoo.com with SMTP; 26 Jun 2014 01:16:10 -0700 PDT Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Subject: Re: svn commit: r267898 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/aggs cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolaris/uts/common/sys From: Pedro Giffuni In-Reply-To: <53ABC9FE.4000107@FreeBSD.org> Date: Thu, 26 Jun 2014 03:16:07 -0500 Message-Id: References: <201406260706.s5Q76hYW014217@svn.freebsd.org> <53ABC9FE.4000107@FreeBSD.org> To: Rui Paulo X-Mailer: Apple Mail (2.1878.2) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Andriy Gapon X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jun 2014 08:21:33 -0000 Il giorno 26/giu/2014, alle ore 02:21, Andriy Gapon ha = scritto: > On 26/06/2014 11:06, Rui Paulo wrote: >> Author: rpaulo >> Date: Thu Jun 26 07:06:43 2014 >> New Revision: 267898 >> URL: http://svnweb.freebsd.org/changeset/base/267898 >>=20 >> Log: >> Bring the following change from the illumos-joyent repository: >>=20 >> commit 78e24ab6803bbe11ba37642624e1498ede5b239d >> Author: Bryan Cantrill >> Date: Thu Oct 31 01:20:54 2013 >>=20 >> OS-1688 DTrace count() with histogram >> OS-2360 DTrace full width distribution histograms >> OS-2361 DTrace frequency trails >>=20 >> MFC after: 2 weeks >=20 > Seems like this change is in illumos already: >=20 > commit 33093f5bcdc51014933497dd39374080c1ac5705 > Author: Bryan Cantrill > Date: Thu Oct 31 08:20:54 2013 +0000 >=20 > 4471 DTrace count() with histogram > 4472 DTrace full width distribution histograms > 4473 DTrace frequency trails > Reviewed by: Dan McDonald > Approved by: Gordon Ross >=20 > As such it would have been preferable to use our standard workflow and > merge the change via the illumos vendor area. >=20 Indeed, this change is in the vendor area: http://svnweb.freebsd.org/base?view=3Drevision&revision=3D266992 However the commit is wrong because: 1) It added files instead of copying them from/through the vendor area. 2) It is not respecting the order in which upstream (Illumos AFAICT) = adds features so it breaks the sense of DT_VERS_LATEST I am aware that DTrace imports have not been respecting the regular = merging procedure but we are trying to work on that. Please fix at least = (1), (2) implies merging three commits that precede this one.=20 Pedro.=