From owner-svn-ports-head@FreeBSD.ORG  Sat Sep  6 09:52:19 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D78D9125;
 Sat,  6 Sep 2014 09:52:19 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id AC4FD1EE3;
 Sat,  6 Sep 2014 09:52:19 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 82B9443BC9;
 Sat,  6 Sep 2014 04:51:52 -0500 (CDT)
Message-ID: <540AD92E.5030602@marino.st>
Date: Sat, 06 Sep 2014 11:51:42 +0200
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: koobs@FreeBSD.org, Carlo Strub <cs@FreeBSD.org>, 
 ports-committers@freebsd.org, svn-ports-all@freebsd.org, 
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r367404 - in head/security: . webshag webshag/files
References: <201409060746.s867kwJ4038485@svn.freebsd.org>
 <540AD4A8.4050705@FreeBSD.org>
In-Reply-To: <540AD4A8.4050705@FreeBSD.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: clutton@zoho.com
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Sep 2014 09:52:20 -0000

On 9/6/2014 11:32, Kubilay Kocak wrote:
> On 6/09/2014 5:46 PM, Carlo Strub wrote:
>> +LICENSE=	GPLv3
> 
> LICENSE_FILE

I know mat's position, but this decree was definitely controversial.
Many people don't agree that LICENSE_FILE is needed when the provided
license is identical to the one offered in ports Templates directory.
And since the licensing framework is still an unsupported and mostly
undocumented red-headed stepchild of ports, I don't think I agree with
saying this was an error.

>> +bin/webshag_cli
>> +%%WXGTK%%bin/webshag_gui
>> +%%ETCDIR%%.conf
> 
> Does this need a filename?


This is probably a wonderful side effect of make makeplist which
aggressively creates SUB replacements, often incorrectly.
This was probably /etc/${PORTNAME}.conf and it got transformed and
submitter didn't check closely enough.

I agree, DO NOT TRUST MAKEPLIST FURTHER THAN YOU CAN THROW IT!


John