From owner-cvs-all Mon Dec 16 16:26:41 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 57D5837B401; Mon, 16 Dec 2002 16:26:40 -0800 (PST) Received: from sccrmhc01.attbi.com (sccrmhc01.attbi.com [204.127.202.61]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8CDB143ED1; Mon, 16 Dec 2002 16:26:39 -0800 (PST) (envelope-from julian@elischer.org) Received: from InterJet.elischer.org (12-232-168-4.client.attbi.com[12.232.168.4]) by sccrmhc01.attbi.com (sccrmhc01) with ESMTP id <2002121700263300100q3gn8e>; Tue, 17 Dec 2002 00:26:33 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id QAA14531; Mon, 16 Dec 2002 16:26:32 -0800 (PST) Date: Mon, 16 Dec 2002 16:26:30 -0800 (PST) From: Julian Elischer To: Matthew Dillon Cc: Nate Lawson , Julian Elischer , cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 dump_machdep.c In-Reply-To: <200212170009.gBH09TFn082087@apollo.backplane.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 16 Dec 2002, Matthew Dillon wrote: > Hmm. Wouldn't this be easier if the test were done after > calculating dumplo? e.g. > > :> dumplo = di->mediaoffset + di->mediasize - Maxmem * (off_t)PAGE_SIZE; > :> dumplo -= sizeof kdh * 2; > no because then you'd have to check fopr dumplo being -ve and I'm of the opinion that blocknumbers should always be unsigned (*) so if this were ever "corrected" to be unsigned, you'd have to check for an overflow which is difficult. (*) there are many bugs showing up at the moment as disks start to get NBLK > 2^31 blocks on them that wouldn't happen if they were unsigned.. I have 3 such devices each with >1TB. If you want to see things explode, just try run sysinstall on them. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message