From owner-cvs-ports@FreeBSD.ORG  Tue Feb 14 06:45:16 2006
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
X-Original-To: cvs-ports@FreeBSD.org
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9B9CA16A420
	for <cvs-ports@FreeBSD.org>; Tue, 14 Feb 2006 06:45:16 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.FreeBSD.org (Postfix) with SMTP id 64D0743D53
	for <cvs-ports@FreeBSD.org>; Tue, 14 Feb 2006 06:45:15 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 66285 invoked by uid 399); 14 Feb 2006 06:45:14 -0000
Received: from localhost (HELO ?192.168.0.5?) (dougb@dougbarton.us@127.0.0.1)
	by localhost with SMTP; 14 Feb 2006 06:45:14 -0000
Message-ID: <43F17C79.1070306@FreeBSD.org>
Date: Mon, 13 Feb 2006 22:45:13 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 1.5 (X11/20060112)
MIME-Version: 1.0
To: Marcus Alves Grando <mnag@FreeBSD.org>
References: <200602131656.k1DGuBHU004721@repoman.freebsd.org>
In-Reply-To: <200602131656.k1DGuBHU004721@repoman.freebsd.org>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/irc/ngircd Makefile ports/irc/ngircd/files
 ngircd.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Feb 2006 06:45:16 -0000

Marcus Alves Grando wrote:
> mnag        2006-02-13 16:56:11 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     irc/ngircd           Makefile 
>   Added files:
>     irc/ngircd/files     ngircd.in 
>   Log:
>   - Use OPTIONS and add more options
>   - Add rc.d script
>   - Bump PORTREVISION
>   
>   PR:             93285  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=93285
>   Submitted by:   mnag
>   Approved by:    maintainer
>   
>   Revision  Changes    Path
>   1.23      +28 -26    ports/irc/ngircd/Makefile
>   1.1       +33 -0     ports/irc/ngircd/files/ngircd.in (new)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/irc/ngircd/Makefile.diff?&r1=1.22&r2=1.23&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/irc/ngircd/files/ngircd.in

This looks good, just two small comments. First, this line is not needed:

: ${ngircd_flags=""}

Second, it's not needed (or desired) to add *_flags to command_args. rc.subr
calls the command like this:

$command $rc_flags $command_args

where rc_flags is the post-processed form of $name_flags.

hth,

Doug

-- 

    This .signature sanitized for your protection