From owner-freebsd-current@FreeBSD.ORG Sat Jan 26 20:14:12 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 0A30BA2A; Sat, 26 Jan 2013 20:14:12 +0000 (UTC) (envelope-from hiren.panchasara@gmail.com) Received: from mail-ee0-f46.google.com (mail-ee0-f46.google.com [74.125.83.46]) by mx1.freebsd.org (Postfix) with ESMTP id 4926FE17; Sat, 26 Jan 2013 20:14:10 +0000 (UTC) Received: by mail-ee0-f46.google.com with SMTP id e49so736402eek.33 for ; Sat, 26 Jan 2013 12:14:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=7ZwNZzRqBziCKgah2d6VnJiyYdFqrcwIeNsI+3IfXPQ=; b=oqn2Ml46Qfxpca43UGdTrptUIHrYnXEqk7SvZBGa4yM0d+yUaTEM0GpMQNK5oLmMs+ TLALAm7ss5+psuZKNVN0i49oJ91OHLGdXgSUiCXDfMWICHpHCSkUUsLO/vHXWofnmM7b FLEOe6ABU3zvD+G4gdWHhqygZjbiiL0lgsPVZsV11NET9weFp1SndDgG+6QEkGolfuJr gh3sR1yfKx52Z+uAEppT3XHxeT5/aEtBoolelAe+Hf89chj+JfdxIlbkAWIQzdfT3iV5 t65i6NLJTr+VjmW7sDDn6R3YnQXsJWaOn59XNm4TZkOlg/VDvZ6OJOYh5EPULTB5xf8+ bDAg== MIME-Version: 1.0 X-Received: by 10.14.174.198 with SMTP id x46mr33317673eel.23.1359231249337; Sat, 26 Jan 2013 12:14:09 -0800 (PST) Received: by 10.14.45.5 with HTTP; Sat, 26 Jan 2013 12:14:09 -0800 (PST) In-Reply-To: References: Date: Sat, 26 Jan 2013 12:14:09 -0800 Message-ID: Subject: Re: hwpmc support for Ivy Bridge Xeon From: hiren panchasara To: Davide Italiano Content-Type: text/plain; charset=UTF-8 Cc: Fabien Thomas , freebsd-current , Jim Harris X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jan 2013 20:14:12 -0000 Keeping sbruno in the chain. On Sat, Jan 26, 2013 at 5:41 AM, Davide Italiano wrote: > On Sat, Jan 26, 2013 at 1:58 AM, hiren panchasara > wrote: >> I've tried to update hwpmc by adding support for xeon class of Ivy >> bridge processors. >> >> Thanks Jim for pointing me to the correct document. (325462-045US Jan 2013) >> >> I do not have a reference machine to test with. Any help in that >> regard would be appreciated. >> >> Here are the diffs against head (245927): >> http://www.strugglingcoder.info/patches/hwpmc_ibx.txt >> >> Thanks, >> Hiren >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > From a first look appears good -- I've a couple of observations though. > I see your patch covers only core events -- am I missing something? My bad, should've mentioned that diffs only has core events. I could not find uncore events clearly mentioned in the spec. > > Not really important, and I don't want to be pedantic here, but maybe > this can be renamed to something less ugly: > > static int > -iap_event_sb_sbx_ib_ok_on_counter(enum pmc_event pe, int ri) > +iap_event_sb_sbx_ib_ibx_ok_on_counter(enum pmc_event pe, int ri) Now when I look at this yes, we should change it. :-) Not sure about the new name. Thanks for looking into it, Hiren