From owner-svn-src-all@FreeBSD.ORG Fri Mar 7 23:01:25 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1F1D19AA; Fri, 7 Mar 2014 23:01:25 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 986F4A0C; Fri, 7 Mar 2014 23:01:24 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.8/8.14.8) with ESMTP id s27Mw0CY085916 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 8 Mar 2014 02:58:00 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.8/8.14.8/Submit) id s27Mw0om085915; Sat, 8 Mar 2014 02:58:00 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sat, 8 Mar 2014 02:58:00 +0400 From: Gleb Smirnoff To: Alan Somers Subject: Re: svn commit: r262867 - in head: sys/kern sys/sys tests/sys/kern Message-ID: <20140307225800.GG80022@FreeBSD.org> References: <201403062024.s26KOFcI085288@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201403062024.s26KOFcI085288@svn.freebsd.org> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2014 23:01:25 -0000 Alan, On Thu, Mar 06, 2014 at 08:24:15PM +0000, Alan Somers wrote: A> Author: asomers A> Date: Thu Mar 6 20:24:15 2014 A> New Revision: 262867 A> URL: http://svnweb.freebsd.org/changeset/base/262867 A> A> Log: A> Fix PR kern/185813 "SOCK_SEQPACKET AF_UNIX sockets with asymmetrical A> buffers drop packets". It was caused by a check for the space available A> in a sockbuf, but it was checking the wrong sockbuf. A> A> sys/sys/sockbuf.h A> sys/kern/uipc_sockbuf.c A> Add sbappendaddr_nospacecheck_locked(), which is just like A> sbappendaddr_locked but doesn't validate the receiving socket's A> space. Factor out common code into sbappendaddr_locked_internal(). A> We shouldn't simply make sbappendaddr_locked check the space and A> then call sbappendaddr_nospacecheck_locked, because that would cause A> the O(n) function m_length to be called twice. A> A> sys/kern/uipc_usrreq.c A> Use sbappendaddr_nospacecheck_locked for SOCK_SEQPACKET sockets, A> because the receiving sockbuf's size limit is irrelevant. A> A> tests/sys/kern/unix_seqpacket_test.c A> Now that 185813 is fixed, pipe_128k_8k fails intermittently due to A> 185812. Make it fail every time by adding a usleep after starting A> the writer thread and before starting the reader thread in A> test_pipe. That gives the writer time to fill up its send buffer. A> Also, clear the expected failure message due to 185813. It actually A> said "185812", but that was a typo. Can you please look at 181741? Seems very much related. -- Totus tuus, Glebius.