From owner-svn-src-all@FreeBSD.ORG Fri Mar 7 23:01:35 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A25F4AE3; Fri, 7 Mar 2014 23:01:35 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8D175A12; Fri, 7 Mar 2014 23:01:35 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s27N1ZER096727; Fri, 7 Mar 2014 23:01:35 GMT (envelope-from asomers@svn.freebsd.org) Received: (from asomers@localhost) by svn.freebsd.org (8.14.8/8.14.8/Submit) id s27N1ZF3096726; Fri, 7 Mar 2014 23:01:35 GMT (envelope-from asomers@svn.freebsd.org) Message-Id: <201403072301.s27N1ZF3096726@svn.freebsd.org> From: Alan Somers Date: Fri, 7 Mar 2014 23:01:35 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r262912 - head/cddl/contrib/opensolaris/lib/libuutil/common X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2014 23:01:35 -0000 Author: asomers Date: Fri Mar 7 23:01:35 2014 New Revision: 262912 URL: http://svnweb.freebsd.org/changeset/base/262912 Log: cddl/contrib/opensolaris/lib/libuutil/common/uu_avl.c Fix a memory leak in uu_avl_pool_create: pthread_mutex_init without a corresponding pthread_mutex_destroy. It shows up, among other places, when doing "zfs list". MFC after: 3 weeks Sponsored by: Spectra Logic Corporation Modified: head/cddl/contrib/opensolaris/lib/libuutil/common/uu_avl.c Modified: head/cddl/contrib/opensolaris/lib/libuutil/common/uu_avl.c ============================================================================== --- head/cddl/contrib/opensolaris/lib/libuutil/common/uu_avl.c Fri Mar 7 22:53:29 2014 (r262911) +++ head/cddl/contrib/opensolaris/lib/libuutil/common/uu_avl.c Fri Mar 7 23:01:35 2014 (r262912) @@ -128,6 +128,7 @@ uu_avl_pool_destroy(uu_avl_pool_t *pp) pp->uap_next->uap_prev = pp->uap_prev; pp->uap_prev->uap_next = pp->uap_next; (void) pthread_mutex_unlock(&uu_apool_list_lock); + (void) pthread_mutex_destroy(&pp->uap_lock); pp->uap_prev = NULL; pp->uap_next = NULL; uu_free(pp);