From owner-freebsd-current@FreeBSD.ORG  Mon Aug 22 21:17:14 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9D68716A41F;
	Mon, 22 Aug 2005 21:17:14 +0000 (GMT)
	(envelope-from dunstan@freebsd.czest.pl)
Received: from freebsd.czest.pl (silver.iplus.pl [80.48.250.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A7ADB43D49;
	Mon, 22 Aug 2005 21:17:12 +0000 (GMT)
	(envelope-from dunstan@freebsd.czest.pl)
Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4])
	by freebsd.czest.pl (8.12.10/8.12.9) with ESMTP id j7MLWNGW022240;
	Mon, 22 Aug 2005 21:32:23 GMT
	(envelope-from dunstan@freebsd.czest.pl)
Received: (from dunstan@localhost)
	by freebsd.czest.pl (8.12.10/8.12.9/Submit) id j7MLWMIF022239;
	Mon, 22 Aug 2005 21:32:22 GMT (envelope-from dunstan)
Date: Mon, 22 Aug 2005 21:32:21 +0000
From: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
To: John Baldwin <jhb@FreeBSD.org>
Message-ID: <20050822213221.GA22155@freebsd.czest.pl>
References: <20050820192601.GA945@freebsd.czest.pl>
	<200508221600.07740.jhb@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200508221600.07740.jhb@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
Cc: freebsd-current@FreeBSD.org
Subject: Re: Locking for ef(4)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Aug 2005 21:17:14 -0000

On Mon, Aug 22, 2005 at 04:00:06PM -0400, John Baldwin wrote:
> On Saturday 20 August 2005 03:26 pm, Wojciech A. Koszek wrote:
> > Hello,
[..]
> 
> You might want to consider using MTX_SYSINIT() to initialize your mutex 
> instead of manually doing it in your module handler routine.  Either that or 
> go ahead and push the calls to mtx_init() and mtx_destroy() into ef_load() 
> and ef_unload() so all the load stuff happens in one function, etc.

I've moved mtx_init and mtx_destroy to ef_load() and ef_unload().
 
> Might also want to check for whitespace breakage in your diffs.  In 
> ef_detach() you replaced the empty line before ether_ifdetach() with a line 
> that contains just a tab.

Fixed. I've also removed also other place with redundant tabs.

Updated patch:
http://freebsd.czest.pl/dunstan/FreeBSD/diff.1.locking.if_ef.c

Thanks!

-- 
* Wojciech A. Koszek && dunstan@FreeBSD.czest.pl