From owner-freebsd-tinderbox@FreeBSD.ORG Tue May 3 01:46:42 2005 Return-Path: Delivered-To: freebsd-tinderbox@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 549F416A4CE; Tue, 3 May 2005 01:46:42 +0000 (GMT) Received: from liberty.onthenet.com.au (liberty.OntheNet.com.au [203.22.124.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 980CF43D7D; Tue, 3 May 2005 01:46:41 +0000 (GMT) (envelope-from grehan@freebsd.org) Received: from [203.13.71.95] (CPE-71-95.dsl.OntheNet.net [203.13.71.95]) j431kdnP003508; Tue, 3 May 2005 11:46:40 +1000 (EST) (envelope-from grehan@freebsd.org) Message-ID: <4276D7F8.304@freebsd.org> Date: Tue, 03 May 2005 11:46:32 +1000 From: Peter Grehan User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20041016 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Maxime Henrion References: <20050502201921.4F0387306E@freebsd-current.sentex.ca> <4276C18F.1080207@freebsd.org> <20050503013209.GA56827@elvis.mu.org> In-Reply-To: <20050503013209.GA56827@elvis.mu.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: powerpc@freebsd.org cc: FreeBSD Tinderbox cc: current@freebsd.org Subject: Re: [current tinderbox] failure on powerpc/powerpc X-BeenThere: freebsd-tinderbox@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Tinderbox reports, responses, and meta-comments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2005 01:46:42 -0000 > While I suppose it might be possible to drop the #if completely, it > would be better to use #if CHAR_MIN == 0 here. That would make it work > for FreeBSD/arm too, as well as any platform where chars are unsigned by > default on which this code may run. Sure - it's not my code so I just did the quickest hack I could to get it compiling. later, Peter.