From owner-cvs-all@FreeBSD.ORG  Mon Mar 28 13:10:42 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2A3E916A4D0; Mon, 28 Mar 2005 13:10:42 +0000 (GMT)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7D2C643D1F; Mon, 28 Mar 2005 13:10:41 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.201] ([192.168.254.201])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.1/8.13.1) with ESMTP id j2SD8VKV099899;
	Mon, 28 Mar 2005 06:08:31 -0700 (MST)
	(envelope-from scottl@samsco.org)
Message-ID: <424801D4.8080902@samsco.org>
Date: Mon, 28 Mar 2005 06:08:36 -0700
From: Scott <scottl@samsco.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.7.5) Gecko/20050321
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Doug Barton <dougb@freebsd.org>
References: <200503280913.j2S9DLIV024748@repoman.freebsd.org>
In-Reply-To: <200503280913.j2S9DLIV024748@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.0.2
X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org
cc: cvs-ports@freebsd.org
cc: cvs-all@freebsd.org
cc: ports-committers@freebsd.org
Subject: Re: cvs commit: ports/x11-wm/windowmaker/files patch-net_wm_icon
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Mar 2005 13:10:42 -0000

On further investigation I think that this is actually due to a bug in
Xlib, not GTK.  This band-aid is enough for 5.4, though.

Scott

Doug Barton wrote:
> dougb       2005-03-28 09:13:21 UTC
> 
>   FreeBSD ports repository
> 
>   Added files:
>     x11-wm/windowmaker/files patch-net_wm_icon 
>   Log:
>   Patch to fix a debilitating problem for amd64 users. To quote Scott:
>   
>   "While it compiles and seems to start fine, it will crash if you
>   start any GTK-based program, including Firefox and Mozilla ...
>   GTK populates the NET_WM_ICON X11 property with incorrectly padded
>   data, and WindowMaker blindly reads it out and winds up passing
>   garbage to some X libraries, which in turn abort the entire process ...
>   Fortunately, handling this X11 property is not mandatory as there are
>   other more reliable ways to pass icon state through X (and in fact very
>   very few other window managers even try this), so it's safe to avoid the
>   whole mess by stubbing it out and letting Windowmaker fall back to a
>   more reliable method."
>   
>   I've tested this patch with i386 windowmaker, and haven't noticed any
>   differences. I have xterms and various other things doing fancy stuff
>   with window and icon titles, so I'm pretty confident that this will
>   be safe for users of all ARCH's. It's also possible that it will help
>   those users who were having weird QT problems, but I was not able to
>   reproduce that problem so I can't say for sure.
>   
>   Submitted by:   scottl
>   Approved by:    portmgr (krion)
>   
>   Revision  Changes    Path
>   1.1       +11 -0     ports/x11-wm/windowmaker/files/patch-net_wm_icon (new)
> _______________________________________________
> cvs-ports@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/cvs-ports
> To unsubscribe, send any mail to "cvs-ports-unsubscribe@freebsd.org"