From owner-svn-src-all@freebsd.org Sun Aug 9 15:59:57 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D857999D470 for ; Sun, 9 Aug 2015 15:59:57 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id ADD7F1D06 for ; Sun, 9 Aug 2015 15:59:57 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by pawu10 with SMTP id u10so122391383paw.1 for ; Sun, 09 Aug 2015 08:59:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=Y4U9kFIYNOq8DfhXftI5ts5wcIVIAA66OKqg6fPqzzc=; b=dMINfFylHA1HOD9t9rt4MA2hhJn+KJjj1BUifdjxfspg5VWFCYlw19dhejfQ9GAKEw /oylZmOdaPHZXVhV2ZpxiWQtMx9HP7qMcn99J336JDGyWMjPWFXw3JW5SIawALQTC6Xi Vc0X63GHQJ3qrQI6Cxyiywq/j+UqwvC1hdcIIruBI0PVFs5kFVn7lshp1IiG9WSW/93j SK+/ngva9DVTbM3LHq+yhQ5MuBjD4gdc1owdW/4tNtNxZ6KB0q+ioPnlXObUuJorQ7N6 nJymnbAqAYnSb6BXrtpADqZS7xFe5KP07WxDJm5ItINf1SaIzKOJdCbFg/Gf7nZIbRiQ apvQ== X-Gm-Message-State: ALoCoQm1KTfIe+KTv4leP05DuG0krfoA895FqtzhcFCPeA9ANdsn58fmIDIY0lVvH8D5fLEs7wiE X-Received: by 10.66.192.162 with SMTP id hh2mr36523395pac.71.1439135991441; Sun, 09 Aug 2015 08:59:51 -0700 (PDT) Received: from [10.64.26.118] ([69.53.236.236]) by smtp.gmail.com with ESMTPSA id nm8sm12928867pbc.20.2015.08.09.08.59.49 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 09 Aug 2015 08:59:50 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r286519 - head/contrib/binutils/gas/config Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Content-Type: multipart/signed; boundary="Apple-Mail=_B63C258E-B2F2-4F1E-B2F0-726E7BBE828F"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5 From: Warner Losh In-Reply-To: <201508091106.t79B6fGN078307@repo.freebsd.org> Date: Sun, 9 Aug 2015 09:59:49 -0600 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201508091106.t79B6fGN078307@repo.freebsd.org> To: Dimitry Andric X-Mailer: Apple Mail (2.2102) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Aug 2015 15:59:58 -0000 --Apple-Mail=_B63C258E-B2F2-4F1E-B2F0-726E7BBE828F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Since when is LEFT shifting a signed number undefined. It is RIGHT shifting that=E2=80=99s undefined=E2=80=A6 Warner > On Aug 9, 2015, at 5:06 AM, Dimitry Andric wrote: >=20 > Author: dim > Date: Sun Aug 9 11:06:40 2015 > New Revision: 286519 > URL: https://svnweb.freebsd.org/changeset/base/286519 >=20 > Log: > In GNU as, avoid left-shifting negative integers, which is undefined. >=20 > MFC after: 3 days >=20 > Modified: > head/contrib/binutils/gas/config/tc-i386.c >=20 > Modified: head/contrib/binutils/gas/config/tc-i386.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/contrib/binutils/gas/config/tc-i386.c Sun Aug 9 = 10:36:25 2015 (r286518) > +++ head/contrib/binutils/gas/config/tc-i386.c Sun Aug 9 = 11:06:40 2015 (r286519) > @@ -914,8 +914,8 @@ fits_in_signed_long (offsetT num ATTRIBU > #ifndef BFD64 > return 1; > #else > - return (!(((offsetT) -1 << 31) & num) > - || (((offsetT) -1 << 31) & num) =3D=3D ((offsetT) -1 << 31)); > + return (!(-((offsetT) 1 << 31) & num) > + || (-((offsetT) 1 << 31) & num) =3D=3D -((offsetT) 1 << 31)); > #endif > } /* fits_in_signed_long() */ >=20 >=20 --Apple-Mail=_B63C258E-B2F2-4F1E-B2F0-726E7BBE828F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVx3j2AAoJEGwc0Sh9sBEAbmwQAJEasQpFomXfXNppBe140ID/ yUG26/ITDXaM/EtJwQNwmeN1BYvDw0WLk/q452UF4Ov+FRWoDiMC0kv+Ngu+o37E mHsbSuGyzMnG6Jbch6h0g4sLzidIKN7Ept4JzdKkEsV24EKs6C7XHNkERFEMhqcp h4nd5wg09O6AacIu8nPP0AAwloZZLxNpE32qvxdiPRsOiY7xd4LIHTrdYpN0CrM4 5JS2yNpUlaJCWX8U/xzdtAoBZOe5KfuQhZAgFbcY3QtlSapPoOliVzpvNHbCCoa+ jCPL2sLXnZTqEjgLspPoKmqrG0eohHDfjaI8b6m+d00AJTtlJagxnT2Lm9KN3ARB 33KDUGyBIypR8EJdW5a5dbQIdgpwrIrBx3GSe70OeQWEa6OB1fQprT3TSb3Zmxd0 VRS7T++7+KCEm9VzfaX49rSA+gRgSxPFGbqotowBoF1iKI6kxtRkwgEJHO5WMfln 0djAgdYecSuzUvrWPmBPntSv5+vAvh97h5bXEAgvgpfDwr4VW/L43/FWOyLUMVsE 43mvuoiYNWeOTMxBRwitIZBc1Ax0JCjw6hggsrpMbhCL6h6qluBT3r9bvzCpl2G5 QjM8j5cuWMlzk3KfyCdkdfB77yPSrjKcPt5skhIAlimwmfEQ5EqDJcXHDPZoFZDE quHhoYYDVnyIhSSUPKjC =dzOF -----END PGP SIGNATURE----- --Apple-Mail=_B63C258E-B2F2-4F1E-B2F0-726E7BBE828F--