From owner-p4-projects  Tue Apr 23 20:14:30 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D9BC937B405; Tue, 23 Apr 2002 20:14:25 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 1912F37B400
	for <perforce@freebsd.org>; Tue, 23 Apr 2002 20:14:25 -0700 (PDT)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g3O3EP963911
	for perforce@freebsd.org; Tue, 23 Apr 2002 20:14:25 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Tue, 23 Apr 2002 20:14:25 -0700 (PDT)
Message-Id: <200204240314.g3O3EP963911@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 10204 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=10204

Change 10204 by rwatson@rwatson_tislabs on 2002/04/23 20:13:49

	Work around existing FreeBSD VFS locking breakage: don't assert
	that vp is locked for mac_cred_check_search_vnode(), because
	apparently it's not.  Existing assertions in lookup() already
	catch this same bug, so it's not our fault (and needs to be
	fixed).

Affected files ...

... //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#128 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#128 (text+ko) ====

@@ -1059,7 +1059,7 @@
 	struct mac dirlabel;
 	int error;
 
-	ASSERT_VOP_LOCKED(dvp, "mac_cred_check_search_vnode");
+	/* XXX: ASSERT_VOP_LOCKED(dvp, "mac_cred_check_search_vnode"); */
 
 	error = VOP_GETLABEL(dvp, &dirlabel, cred, curthread);
 	if (error)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message