From owner-svn-src-all@FreeBSD.ORG  Mon Dec 15 14:47:32 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 6B14DE10;
 Mon, 15 Dec 2014 14:47:32 +0000 (UTC)
Received: from mail-ig0-x229.google.com (mail-ig0-x229.google.com
 [IPv6:2607:f8b0:4001:c05::229])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 30C9D7E9;
 Mon, 15 Dec 2014 14:47:32 +0000 (UTC)
Received: by mail-ig0-f169.google.com with SMTP id hl2so6044223igb.0;
 Mon, 15 Dec 2014 06:47:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:content-type;
 bh=RYyGMV3Mq5RnGVRcdiNLyNNUMdCw/5t2aWt568c3ejE=;
 b=pGjI6ux2VXs59XnhihnaCPKbu3WogRIdfBxuNfFMjfBWK3wUndLTHmskJvlg3k+4wB
 rsUvZExwwDjZMO3IIZHM2Y1D6mgKbvL1gq4nDMF1a2TlC30Qvz/MCuUy/nk6WSIEAvis
 tVlxV7lVCQcLHsGl+h4CvzzZt5OJPsbRqaD9gghKVW2N+dcyOiG9drITM8MMPNstSHsQ
 oeuZ4fAqpHAeunwam2sE82+lLlc3C0uXMHlZhC2tfhDeirb98dLCokE04HPKnXZ8HfCk
 hkEqikobvx28bLCgOWhIwrKJu7qEC7ZUqlWQ1DXNz2f4fAhInCijYgvhW/rPewODuppn
 TkBw==
X-Received: by 10.50.142.98 with SMTP id rv2mr17943090igb.19.1418654851523;
 Mon, 15 Dec 2014 06:47:31 -0800 (PST)
MIME-Version: 1.0
Sender: carpeddiem@gmail.com
Received: by 10.107.0.85 with HTTP; Mon, 15 Dec 2014 06:47:11 -0800 (PST)
In-Reply-To: <201412151425.sBFEPhhs009026@svn.freebsd.org>
References: <201412151425.sBFEPhhs009026@svn.freebsd.org>
From: Ed Maste <emaste@freebsd.org>
Date: Mon, 15 Dec 2014 09:47:11 -0500
X-Google-Sender-Auth: sk5tARbcqIRFAIJDi_3nz0_lgqM
Message-ID: <CAPyFy2C6aaRrOxzv2WxPH_FKR1zz_TyN04EhDYV-FMXpuXmmxg@mail.gmail.com>
Subject: Re: svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus
To: "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Dec 2014 14:47:32 -0000

On 15 December 2014 at 09:25, Ed Maste <emaste@freebsd.org> wrote:
> Author: emaste
> Date: Mon Dec 15 14:25:42 2014
> New Revision: 275804
> URL: https://svnweb.freebsd.org/changeset/base/275804
>
> Log:
>   Remove empty generated file upon gperf failure
>...
> -           ${.ALLSRC} > ${.TARGET}
> +           ${.ALLSRC} > ${.TARGET} || (rm -f ${.TARGET}; false)

There are additional cases of this potential issue in the tree. In
most cases I examined the target invokes tools that are expected to
exist on the build host (such as sed or awk) so should not be a
problem in practice. There are some cases (gensnmptree, make-roken)
that we may want to revisit as part of a more holistic build
infrastructure project.