From owner-freebsd-bugs Thu Sep 13 0:20: 9 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 10ED237B40C for ; Thu, 13 Sep 2001 00:20:02 -0700 (PDT) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.4/8.11.4) id f8D7K2S07967; Thu, 13 Sep 2001 00:20:02 -0700 (PDT) (envelope-from gnats) Date: Thu, 13 Sep 2001 00:20:02 -0700 (PDT) Message-Id: <200109130720.f8D7K2S07967@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Ruslan Ermilov Subject: Re: bin/30538: [PATCH] ownerships pedantry Reply-To: Ruslan Ermilov Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/30538; it has been noted by GNATS. From: Ruslan Ermilov To: Tony Finch Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: bin/30538: [PATCH] ownerships pedantry Date: Thu, 13 Sep 2001 10:13:51 +0300 On Thu, Sep 13, 2001 at 12:37:17AM +0000, Tony Finch wrote: > > A number of programs set BINOWN and BINGRP to non-standard values > for no obvious reason. They are: > ping6 > traceroute6 > doscmd > > There are also some oddities in the games handling in bsd.prog.mk > which fails to set the ownership of a hidden game symlink correctly. > > Index: sbin/ping6/Makefile > =================================================================== > RCS file: /home/ncvs/src/sbin/ping6/Makefile,v > retrieving revision 1.1.2.2 > diff -u -r1.1.2.2 Makefile > --- sbin/ping6/Makefile 2001/04/25 10:58:46 1.1.2.2 > +++ sbin/ping6/Makefile 2001/06/27 18:25:29 > @@ -5,8 +5,6 @@ > > CFLAGS+=-DINET6 -DIPSEC > > -BINOWN= root > -BINGRP= bin > BINMODE=4555 > We need BINOWN=root explicitly for setuid root binaries. One may have non-default value of BINOWN in /etc/make.conf, and we still want these to be installed setuid root in this case. I've just fixed that (in all cases). BINGRP=bin is not present in -CURRENT. Kris was going to MFC this. > Index: usr.sbin/traceroute6/Makefile > =================================================================== > RCS file: /home/ncvs/src/usr.sbin/traceroute6/Makefile,v > retrieving revision 1.2.2.2 > diff -u -r1.2.2.2 Makefile > --- usr.sbin/traceroute6/Makefile 2001/04/25 12:11:06 1.2.2.2 > +++ usr.sbin/traceroute6/Makefile 2001/06/27 18:26:13 > @@ -15,8 +15,6 @@ > > PROG= traceroute6 > > -BINOWN= root > -BINGRP= bin > BINMODE=4555 > I've removed BINGRP. BINOWN should stay for above mentioned reasons. > Index: share/mk/bsd.prog.mk > =================================================================== > RCS file: /home/ncvs/src/share/mk/bsd.prog.mk,v > retrieving revision 1.86.2.4 > diff -u -r1.86.2.4 bsd.prog.mk > --- share/mk/bsd.prog.mk 2001/08/01 17:14:26 1.86.2.4 > +++ share/mk/bsd.prog.mk 2001/09/07 17:35:20 > @@ -107,7 +107,7 @@ > .endif > .if defined(HIDEGAME) > (cd ${DESTDIR}/${GBINDIR}; rm -f ${PROG}; ln -s dm ${PROG}; \ > - chown games:bin ${PROG}) > + chown -h ${BINOWN}:${BINGRP} ${PROG}) > .endif > .if defined(LINKS) && !empty(LINKS) > @set ${LINKS}; \ > Again, this is not the problem in -CURRENT. See bsd.prog.mk, revisions 1.98-1.100. This was triggered by corresponding change to chown(8), which now does (in -CURRENT) follow symbolic links specified on a command line in the non -R case. This will be MFC'ed at some time I think. > Index: usr.bin/doscmd/Makefile > =================================================================== > RCS file: /home/ncvs/src/usr.bin/doscmd/Makefile,v > retrieving revision 1.21.2.3 > diff -u -r1.21.2.3 Makefile > --- usr.bin/doscmd/Makefile 2001/08/02 02:17:15 1.21.2.3 > +++ usr.bin/doscmd/Makefile 2001/08/28 22:22:53 > @@ -22,7 +22,6 @@ > .endif > > BINGRP= kmem > -EXEGRP= bin > #BINMODE= 2555 > EXEMODE= 444 > EXEGRP and EXEMODE are used to install DOS (EXE format) files. EXEGRP is used instead of BINGRP because once upon a time this binary was installed ``setgid kmem'', and BINGRP=kmem is not feasible for EXE files. One fix would be to remove BINGRP and (commented out) BINMODE, and make EXEGRP=${BINGRP}. But I would like to preserve (the commented out) fact that this binary may be run ``setgid kmem''. May I close this PR now? Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message