From owner-svn-src-all@FreeBSD.ORG  Wed Jul  9 21:55:34 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 97609424;
 Wed,  9 Jul 2014 21:55:34 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 84B9D2EDD;
 Wed,  9 Jul 2014 21:55:34 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s69LtYFg047001;
 Wed, 9 Jul 2014 21:55:34 GMT (envelope-from ray@svn.freebsd.org)
Received: (from ray@localhost)
 by svn.freebsd.org (8.14.8/8.14.8/Submit) id s69LtYO2047000;
 Wed, 9 Jul 2014 21:55:34 GMT (envelope-from ray@svn.freebsd.org)
Message-Id: <201407092155.s69LtYO2047000@svn.freebsd.org>
From: Aleksandr Rybalko <ray@FreeBSD.org>
Date: Wed, 9 Jul 2014 21:55:34 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r268472 - head/sys/dev/fb
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jul 2014 21:55:34 -0000

Author: ray
Date: Wed Jul  9 21:55:34 2014
New Revision: 268472
URL: http://svnweb.freebsd.org/changeset/base/268472

Log:
  Should check fb_read method presence instead of double check for fb_write.
  
  Pointed by:     emaste
  
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/sys/dev/fb/fbd.c

Modified: head/sys/dev/fb/fbd.c
==============================================================================
--- head/sys/dev/fb/fbd.c	Wed Jul  9 21:39:40 2014	(r268471)
+++ head/sys/dev/fb/fbd.c	Wed Jul  9 21:55:34 2014	(r268472)
@@ -246,7 +246,7 @@ fb_probe(struct fb_info *info)
 		return (ENXIO);
 
 	if (info->fb_write != NULL) {
-		if (info->fb_write == NULL) {
+		if (info->fb_read == NULL) {
 			return (EINVAL);
 		}
 		info->fb_flags |= FB_FLAG_NOMMAP;